Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"storageevent" argument for Document::createEvent #10831

Merged
merged 1 commit into from Apr 25, 2016

Conversation

@mskrzypkows
Copy link

mskrzypkows commented Apr 25, 2016

Fixes #10736


This change is Reviewable

@highfive
Copy link

highfive commented Apr 25, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/dom/storageevent.rs
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 25, 2016

Thanks!

@bors-servo r+

Btw, if you'd be interested in doing a little more complex work, we can make that happen too :)

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

📌 Commit 6187ee6 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

Testing commit 6187ee6 with merge 8bf732e...

bors-servo added a commit that referenced this pull request Apr 25, 2016
"storageevent" argument for Document::createEvent

Fixes  #10736

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10831)
<!-- Reviewable:end -->
@mskrzypkows
Copy link
Author

mskrzypkows commented Apr 25, 2016

@Ms2ger sure, I can do something more challenging :-) Will you propose me something?

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

@bors-servo bors-servo merged commit 6187ee6 into servo:master Apr 25, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.