Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadded support for :read-only and :read-write pseudo-classes #10834
Conversation
highfive
commented
Apr 25, 2016
|
Looks good, thanks! @bors-servo r+ Reviewed 8 of 8 files at r1. Comments from Reviewable |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 26, 2016
added support for :read-only and :read-write pseudo-classes partial fix for #10732 It's not a full fix because: 1. there's a bug in wpt-test web-platform-tests/wpt#2889 (comment) 2. we don't fully support all input types (namely image, color, hidden and range), which are defaulted to input text. this means that :read-write which is applicable to input text is mis-handled in those cases. 3. we don't support contenteditable, which is also possibly :read-write <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10834) <!-- Reviewable:end -->
|
|
|
fixed the failing ./mach build-geckolib test |
|
@bors-servo r+ Reviewed 2 of 2 files at r2. Comments from Reviewable |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2016
added support for :read-only and :read-write pseudo-classes partial fix for #10732 It's not a full fix because: 1. there's a bug in wpt-test web-platform-tests/wpt#2889 (comment) 2. we don't fully support all input types (namely image, color, hidden and range), which are defaulted to input text. this means that :read-write which is applicable to input text is mis-handled in those cases. 3. we don't support contenteditable, which is also possibly :read-write <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10834) <!-- Reviewable:end -->
|
|
highfive
commented
Apr 29, 2016
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2016
added support for :read-only and :read-write pseudo-classes partial fix for #10732 It's not a full fix because: 1. there's a bug in wpt-test web-platform-tests/wpt#2889 (comment) 2. we don't fully support all input types (namely image, color, hidden and range), which are defaulted to input text. this means that :read-write which is applicable to input text is mis-handled in those cases. 3. we don't support contenteditable, which is also possibly :read-write <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10834) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yoava333 commentedApr 25, 2016
partial fix for #10732
It's not a full fix because:
This change is