Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "progressevent" argument to Document::createEvent #10844

Merged
merged 1 commit into from Apr 26, 2016

Conversation

@ziyunli
Copy link
Contributor

ziyunli commented Apr 26, 2016

Fixes #10740


This change is Reviewable

@highfive
Copy link

highfive commented Apr 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/dom/progressevent.rs
@frewsxcv
Copy link
Member

frewsxcv commented Apr 26, 2016

Thanks! @bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

📌 Commit 2de52d9 has been approved by frewsxcv

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

Testing commit 2de52d9 with merge a82e7d4...

bors-servo added a commit that referenced this pull request Apr 26, 2016
Implement the "progressevent" argument to Document::createEvent

Fixes #10740

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

💔 Test failed - mac-rel-wpt

@highfive
Copy link

highfive commented Apr 26, 2016

  ▶ Unexpected subtest result in /dom/events/ProgressEvent.html:
  │ FAIL [expected PASS] document.createEvent() should not work with ProgressEvent.
  │   → assert_throws: functio</span><span class="stdout">n &#34;function () {
    document.createEvent(&#34;ProgressEvent&#34;)
  }&#34; did not throw
  │ 
  │ @http://web-platform.test:8000/dom/events/ProgressEvent.html:15:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/dom/events/ProgressEvent.html:14:1
@frewsxcv frewsxcv assigned frewsxcv and unassigned metajack Apr 26, 2016
@frewsxcv
Copy link
Member

frewsxcv commented Apr 26, 2016

web-platform-tests/wpt#2897

For now, just mark that test as failing. If you need help doing that, let me know.

@ziyunli ziyunli force-pushed the ziyunli:10740 branch from 2de52d9 to 889579c Apr 26, 2016
@ziyunli
Copy link
Contributor Author

ziyunli commented Apr 26, 2016

@frewsxcv
Copy link
Member

frewsxcv commented Apr 26, 2016

Looks great, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

📌 Commit 889579c has been approved by frewsxcv

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

Testing commit 889579c with merge 09b2efc...

bors-servo added a commit that referenced this pull request Apr 26, 2016
Implement the "progressevent" argument to Document::createEvent

Fixes #10740

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

@bors-servo bors-servo merged commit 889579c into servo:master Apr 26, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ziyunli ziyunli deleted the ziyunli:10740 branch Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.