Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove abstract parser infrastructure from servohtmlparser.rs to parse #10866
Conversation
highfive
commented
Apr 26, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon. |
highfive
commented
Apr 26, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 26, 2016
|
This looks great! All I can find to complain about is a few whitespace nits, so I'll do that :) -S-awaiting-review +S-needs-code-changes r? @Ms2ger Reviewed 5 of 5 files at r1. components/script/dom/servohtmlparser.rs, line 39 [r1] (raw file): components/script/dom/servohtmlparser.rs, line 55 [r1] (raw file): components/script/parse/mod.rs, line 5 [r1] (raw file): components/script/parse/mod.rs, line 25 [r1] (raw file): components/script/parse/mod.rs, line 49 [r1] (raw file): components/script/parse/mod.rs, line 180 [r1] (raw file): Comments from Reviewable |
|
removed double empty lines. |
|
Thanks! just needs a squash now; let me know if you need help with that. -S-awaiting-review +S-needs-squash Reviewed 2 of 2 files at r2. Comments from Reviewable |
|
the idea is to make one commit out of it... like the second last point in the git workflow?
|
|
Yep. |
|
done. |
|
@bors-servo r+ Thanks! |
|
|
Move abstract parser infrastructure from servohtmlparser.rs to parse Fixes #10856 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10866) <!-- Reviewable:end -->
|
|
broesamle commentedApr 26, 2016
•
edited by KiChjang
Fixes #10856
This change is