Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move abstract parser infrastructure from servohtmlparser.rs to parse #10866

Merged
merged 1 commit into from Apr 27, 2016

Conversation

@broesamle
Copy link
Contributor

broesamle commented Apr 26, 2016

Fixes #10856


This change is Reviewable

@highfive
Copy link

highfive commented Apr 26, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.

@highfive
Copy link

highfive commented Apr 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/parse/mod.rs, components/script/dom/document.rs, components/script/dom/servohtmlparser.rs, components/script/dom/servoxmlparser.rs, components/script/script_thread.rs
@highfive
Copy link

highfive commented Apr 26, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 27, 2016

This looks great! All I can find to complain about is a few whitespace nits, so I'll do that :)

-S-awaiting-review +S-needs-code-changes

r? @Ms2ger


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.


components/script/dom/servohtmlparser.rs, line 39 [r1] (raw file):
Revert those two new empty lines, please.


components/script/dom/servohtmlparser.rs, line 55 [r1] (raw file):
There's now three empty lines below this; one should be enough.


components/script/parse/mod.rs, line 5 [r1] (raw file):
Just one empty line between license and imports.


components/script/parse/mod.rs, line 25 [r1] (raw file):
And just one here...


components/script/parse/mod.rs, line 49 [r1] (raw file):
And here


components/script/parse/mod.rs, line 180 [r1] (raw file):
And no empty line at the end here.


Comments from Reviewable

@broesamle
Copy link
Contributor Author

broesamle commented Apr 27, 2016

removed double empty lines.
hope I found all.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 27, 2016

Thanks! just needs a squash now; let me know if you need help with that.

-S-awaiting-review +S-needs-squash


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@broesamle
Copy link
Contributor Author

broesamle commented Apr 27, 2016

the idea is to make one commit out of it... like the second last point in the git workflow?

$ git rebase -i --autosquash <mozilla>/master

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 27, 2016

Yep.

@broesamle broesamle force-pushed the broesamle:issue10856-a branch from 39129f9 to 7c4489b Apr 27, 2016
@broesamle
Copy link
Contributor Author

broesamle commented Apr 27, 2016

done.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 27, 2016

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

📌 Commit 7c4489b has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

Testing commit 7c4489b with merge 5fd93de...

bors-servo added a commit that referenced this pull request Apr 27, 2016
Move abstract parser infrastructure from servohtmlparser.rs to parse

Fixes #10856

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10866)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

@bors-servo bors-servo merged commit 7c4489b into servo:master Apr 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@broesamle broesamle deleted the broesamle:issue10856-a branch Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.