Commits on Apr 28, 2016

1. Don't assume the first glyph is part of the first char …

   Shaper::save_glyph_results incorrectly starts its loop by setting glyph_span
   to a length of 1.  This means that the `if glyph_span.len() == 0` test in the
   inner loop will never succeed.
   
   Instead the glyph span should start out empty, and a glyph should be added only
   as the corresponding char is found.  For comparison, see the Gecko code this
   was ported from:
   
   https://hg.mozilla.org/mozilla-central/file/ab0044bf/gfx/thebes/gfxHarfBuzzShaper.cpp#l1682

   

   mbrubeck committed Apr 28, 2016
   97a58e9

2. Remove unneeded add_nonglyph_for_char_index …

   This is a no-op, since a "non-glyph" is simply `GlyphEntry(0)`. This is the
   same as `GlyphEntry::initial()`, which all the entries are already initialized
   to.

   

   mbrubeck committed Apr 28, 2016
   dba878d

3. Use byte indices instead of char indices for text runs …

   Replace character indices with UTF-8 byte offsets throughout the code dealing
   with text shaping and breaking.  This eliminates a lot of complexity when
   converting from one to the other, and interoperates better with the rest of
   the Rust ecosystem.

   

   mbrubeck committed Apr 28, 2016

   Loading status checks…
   659305f

4. Replace range::Range with std::ops::Range in script

   

   mbrubeck committed Apr 28, 2016

   Loading status checks…
   c4872d9