Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the requesting URL to the 401 prompt. Only show the 401 prompt wh… #10932

Merged
merged 1 commit into from May 4, 2016
Merged

Add the requesting URL to the 401 prompt. Only show the 401 prompt wh… #10932

merged 1 commit into from May 4, 2016

Conversation

@jdm
Copy link
Member

jdm commented Apr 29, 2016 •
edited by larsbergstrom

…en the WWW-Authenticate header is present.

Fixes #10912.

This change is Reviewable
@highfive
Copy link

highfive commented Apr 29, 2016

Heads up! This PR modifies the following files:
@SimonSapin
Copy link
Member

SimonSapin commented Apr 29, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2016

📌 Commit 7abf3ab has been approved by SimonSapin
@frewsxcv
Copy link
Member

frewsxcv commented Apr 29, 2016

How difficult would a regression test be?
@jdm
Copy link
Member Author

jdm commented Apr 30, 2016

A unit test would be very easy.
@jdm
Copy link
Member Author

jdm commented Apr 30, 2016

@bors-servo: r-
@jdm jdm added S-needs-tests and removed S-awaiting-merge labels May 2, 2016
@jdm
Add the requesting URL to the 401 prompt. Only show the 401 prompt wh…
Loading status checks…
cb63ad6 
…en the WWW-Authenticate header is present.
@jdm jdm force-pushed the jdm:401 branch from 7abf3ab to cb63ad6 May 3, 2016
@highfive
Copy link

highfive commented May 3, 2016

New code was committed to pull request.
@jdm jdm removed the S-needs-tests label May 3, 2016
@SimonSapin
Copy link
Member

SimonSapin commented May 4, 2016

@bors-servo r+

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2016

📌 Commit cb63ad6 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2016

⌛ Testing commit cb63ad6 with merge 20fc8b3...
bors-servo added a commit that referenced this pull request May 4, 2016
@bors-servo
Auto merge of #10932 - jdm:401, r=SimonSapin
Loading status checks…
20fc8b3 
Add the requesting URL to the 401 prompt. Only show the 401 prompt wh…

…en the WWW-Authenticate header is present.

Fixes #10912.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10932)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request May 4, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented May 4, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit cb63ad6 into servo:master May 4, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @SimonSapin @bors-servo @frewsxcv
You can’t perform that action at this time.