Change OSX 'activiation policy' when running headless mode. #10935

frewsxcv · 2016-04-29T21:06:46Z

...or also when outputting a file.

Fixes #10836.

This change is

frewsxcv · 2016-04-29T21:08:55Z

This might also fix #9513?

cc @jdm @larsbergstrom

larsbergstrom · 2016-04-29T21:09:08Z

@bors-servo r+

bors-servo · 2016-04-29T21:09:08Z

📌 Commit 6b77751 has been approved by larsbergstrom

jdm · 2016-04-29T21:09:39Z

This is missing an update for ports/cef/Cargo.lock.

frewsxcv · 2016-04-29T21:11:36Z

@bors-servo r=larsbergstrom

bors-servo · 2016-04-29T21:11:37Z

📌 Commit c4ed5f0 has been approved by larsbergstrom

aneeshusa · 2016-04-29T21:51:54Z

ports/glutin/window.rs

+fn builder_with_platform_options(mut builder: glutin::WindowBuilder)-> glutin::WindowBuilder {
+    if opts::get().headless || opts::get().output_file.is_some() {
+        // Prevent the window from showing in Dock.app, stealing focus,
+        // or appaearing at all when running in headless mode or generating an


spelling: appearing

frewsxcv · 2016-04-29T23:03:04Z

Fixed the typo

@bors-servo r=larsbergstrom

bors-servo · 2016-04-29T23:03:22Z

📌 Commit b1660a5 has been approved by larsbergstrom

pcwalton · 2016-04-29T23:05:15Z

@bors-servo: r=larsbergstrom p=10

This makes bots run tests faster so a higher priority will help the queue clear out

bors-servo · 2016-04-29T23:05:16Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #10899

bors-servo · 2016-04-29T23:05:17Z

📌 Commit b1660a5 has been approved by larsbergstrom


        Auto merge of #10935 - frewsxcv:activation-policy, r=larsbergstrom

Change OSX 'activiation policy' when running headless mode. ...or also when outputting a file. Fixes #10836.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10935)

bors-servo · 2016-04-30T02:41:59Z

💔 Test failed - mac-dev-unit

frewsxcv · 2016-04-30T03:13:54Z

Updated lockfiles. Didn't know that cef required servo-glutin

@bors-servo: r=larsbergstrom p=10

bors-servo · 2016-04-30T03:13:55Z

📌 Commit 001cee8 has been approved by larsbergstrom

jdm · 2016-04-30T03:15:06Z

I did point it out 6 hours ago :)

frewsxcv · 2016-04-30T03:17:03Z

I did point it out 6 hours ago :)

I thought ports/glutin was the only "port" that required glutin, so I didn't bother trying to update it (I did update cocoa-rs). Though I should probably stop assuming these things :P


        Change OSX 'activation policy' when running headless mode.

...or also when outputting a file. Fixes #10836.

frewsxcv · 2016-04-30T03:43:08Z

Tidy fail

@bors-servo: r=larsbergstrom p=10

bors-servo · 2016-04-30T03:43:21Z

📌 Commit 71af66a has been approved by larsbergstrom

bors-servo · 2016-04-30T03:43:30Z

⌛ Testing commit 71af66a with merge f6a5ecb...


        Auto merge of #10935 - frewsxcv:activation-policy, r=larsbergstrom

Change OSX 'activiation policy' when running headless mode. ...or also when outputting a file. Fixes #10836.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10935)

bors-servo · 2016-04-30T05:46:15Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned emilio Apr 29, 2016

highfive added the S-awaiting-review label Apr 29, 2016

frewsxcv force-pushed the frewsxcv:activation-policy branch 2 times, most recently from 8e08c63 to 6b77751 Apr 29, 2016

highfive assigned larsbergstrom and unassigned emilio Apr 29, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 29, 2016

frewsxcv force-pushed the frewsxcv:activation-policy branch from 6b77751 to c4ed5f0 Apr 29, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Apr 29, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 29, 2016

aneeshusa reviewed Apr 29, 2016
View changes

frewsxcv force-pushed the frewsxcv:activation-policy branch from c4ed5f0 to b1660a5 Apr 29, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Apr 29, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 29, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 30, 2016

frewsxcv force-pushed the frewsxcv:activation-policy branch from 88b31b9 to 001cee8 Apr 30, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Apr 30, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 30, 2016

Change OSX 'activation policy' when running headless mode.

Loading status checks…

71af66a

...or also when outputting a file. Fixes #10836.

frewsxcv force-pushed the frewsxcv:activation-policy branch from 001cee8 to 71af66a Apr 30, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Apr 30, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 30, 2016

bors-servo merged commit 71af66a into servo:master Apr 30, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 30, 2016

bors-servo mentioned this pull request Apr 30, 2016

Removed sources of panic from ports/glutin. #10910

Merged

frewsxcv deleted the frewsxcv:activation-policy branch Apr 30, 2016

frewsxcv mentioned this pull request Apr 30, 2016

OSX tests that spawn windows blast the WindowServer process #9513

Closed

aneeshusa mentioned this pull request May 6, 2016

This increases the number of processes on the Mac builders. servo/saltfs#366

Merged

servo / servo

Change OSX 'activiation policy' when running headless mode. #10935

Change OSX 'activiation policy' when running headless mode. #10935

frewsxcv commented Apr 29, 2016 •

edited

frewsxcv commented Apr 29, 2016

larsbergstrom commented Apr 29, 2016

bors-servo commented Apr 29, 2016

jdm commented Apr 29, 2016

frewsxcv commented Apr 29, 2016

bors-servo commented Apr 29, 2016

This comment has been minimized.

frewsxcv commented Apr 29, 2016

bors-servo commented Apr 29, 2016

pcwalton commented Apr 29, 2016

bors-servo commented Apr 29, 2016

bors-servo commented Apr 29, 2016

bors-servo commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

bors-servo commented Apr 30, 2016

jdm commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

bors-servo commented Apr 30, 2016

bors-servo commented Apr 30, 2016

bors-servo commented Apr 30, 2016

servo / servo

Join GitHub today

Change OSX 'activiation policy' when running headless mode. #10935

Change OSX 'activiation policy' when running headless mode. #10935

Conversation

frewsxcv commented Apr 29, 2016 • edited

frewsxcv commented Apr 29, 2016

larsbergstrom commented Apr 29, 2016

bors-servo commented Apr 29, 2016

jdm commented Apr 29, 2016

frewsxcv commented Apr 29, 2016

bors-servo commented Apr 29, 2016

This comment has been minimized.

aneeshusa Apr 29, 2016

frewsxcv commented Apr 29, 2016

bors-servo commented Apr 29, 2016

pcwalton commented Apr 29, 2016

bors-servo commented Apr 29, 2016

bors-servo commented Apr 29, 2016

bors-servo commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

bors-servo commented Apr 30, 2016

jdm commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

frewsxcv commented Apr 30, 2016

bors-servo commented Apr 30, 2016

bors-servo commented Apr 30, 2016

bors-servo commented Apr 30, 2016

frewsxcv commented Apr 29, 2016 •

edited