./mach run --browserhtml on Windows

[adamncasey]

This adds some windows specific behaviour to the ./mach run --browserhtml command:

Remove the webrender option
Convert the browserhtml path into a relative path to avoid a mingw->windows path conversion.

@larsbergstrom said that webrender support will come to windows ( #10243 (comment) ), which will remove the need for part of this soon. But it makes testing slightly nicer.

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @wafflespeanut: python/servo/command_base.py, python/servo/post_build_commands.py

[adamncasey]

I'm not totally convinced by converting it to a relative path. But it happens to work around the problem of msys python generating a unix format path, and servo expecting paths in windows' format.

[larsbergstrom]

@bors-servo r+

I'm approving this so that it can be tested, but I do not expect browser.html to work at all well with the default CPU renderer. Like most other browser engines, it does quite poorly on such a complicated page.

[bors-servo]

📌 Commit 738ae67 has been approved by larsbergstrom

[bors-servo]

⌛ Testing commit 738ae67 with merge f935a14...

[bors-servo]

💔 Test failed - mac-rel-css

[adamncasey]

I'll fix the tidy problems & push a new commit soon

[UK992]

With servo/webrender#247 made Webrender actually work well on Windows. I've been testing it for a month now.

EDIT: Browser.html, via --browserhtml open blank window, when directly via path from same source with -w it works fine.

[UK992]

Now that Webrender PR for Windows was merged, may i suggest to exclude command -b instead, because window without native titlebar is currently useless on Windows.

[adamncasey]

That seems sensible

[adamncasey]

Does disabling the titlebar work on Linux? It might make more sense to only pass -b if it's running on a mac

[paulrouget]

Does disabling the titlebar work on Linux?

No.

[highfive]

New code was committed to pull request.

[adamncasey]

I don't have an appropriate box to test this on, but borderless should now only enable on OSX.

When the dependency on webrender is updated past servo/webrender@672a360 --browserhtml will also work on Windows

[jasonwilliams]

@larsbergstrom ^

[bors-servo]

☔ The latest upstream changes (presumably #11332) made this pull request unmergeable. Please resolve the merge conflicts.

[metajack]

Windows webrender seems to work fine on master. What am I missing?

Previously, bors-servo wrote…

☔ The latest upstream changes (presumably #11332) made this pull request unmergeable. Please resolve the merge conflicts.

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

python/servo/command_base.py, line 110 [r1] (raw file):

    if sys.platform == 'win32':
        return True
    if platform.system() == 'Windows':

I think this can be written simply as:

return sys.platform == 'win32' or sys.platform = 'msys'

---

Comments from Reviewable

[larsbergstrom]

I don't think we need this anymore, now that WebRender on master works on Windows. Hooray!

[UK992]

@larsbergstrom Webrender is solved, but latest commit disable useless borderless window and fix browser.html path related issue (described above).