Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI bash scripts #10948

Merged
merged 2 commits into from May 1, 2016
Merged

Clean up CI bash scripts #10948

merged 2 commits into from May 1, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented May 1, 2016 •
edited by larsbergstrom

Also reverts #9572.

This change is Reviewable
@highfive
Copy link

highfive commented May 1, 2016

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/check_no_unwrap.sh, etc/ci/manifest_changed.sh, etc/ci/upload_docs.sh, etc/ci/retry.sh, etc/ci/lockfile_changed.sh
STYLE_GUIDE.md Outdated
@@ -0,0 +1,29 @@
# Style Guide

This comment has been minimized.

Sign in to view
Copy link
@frewsxcv

frewsxcv May 1, 2016

Member

maybe this should go in the docs folder?
aneeshusa added 2 commits May 1, 2016
@aneeshusa
Clean up CI bash scripts, add docs/STYLE_GUIDE.md
1e0d039
@aneeshusa
Remove etc/ci/retry.sh
Loading status checks…
cca3f7a 
It was added with the intention of being used on the CI,
but it was never added to the CI. We have better ways of finding
test failures and intermittents these days.
@aneeshusa aneeshusa force-pushed the aneeshusa:clean-up-ci-bash-scripts branch from 946f4c1 to cca3f7a May 1, 2016
@emilio
Copy link
Member

emilio commented May 1, 2016

Looks good to me, thanks for doing this!

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2016

📌 Commit cca3f7a has been approved by emilio
@highfive highfive assigned emilio and unassigned asajeffrey May 1, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2016

⌛ Testing commit cca3f7a with merge 288db30...
bors-servo added a commit that referenced this pull request May 1, 2016
@bors-servo
Auto merge of #10948 - aneeshusa:clean-up-ci-bash-scripts, r=emilio
Loading status checks…
288db30 
Clean up CI bash scripts

Also reverts #9572.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10948)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit cca3f7a into servo:master May 1, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@aneeshusa @highfive @emilio @bors-servo @frewsxcv @asajeffrey
You can’t perform that action at this time.