Ensure that a navigation to the same URL is aborted. Fixes #10952.

[jdm]

This change is

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/script_thread.rs

[KiChjang]

-S-awaiting-review +S-needs-code-changes

r=me after that small nit.

---

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/script/script_thread.rs, line 1791 [r1] (raw file):
Can we move the above 3 lines into the if-body? It doesn't seem to be necessary to initialize and allocate resources for these variables if the condition turns out to be false.

---

Comments from Reviewable

[KiChjang]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

components/script/script_thread.rs, line 1800 [r1] (raw file):
Hold on, the algorithm is only aborted when there is a fragment for nurl, so this should move 1 line up.

---

Comments from Reviewable

[emilio]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

components/script/script_thread.rs, line 1800 [r1] (raw file):
Yes, I think Keith is right here, the problem is that setting location.hash to an empty string seems to follow this code path, which sets the url fragment to None instead of Some("").

This seems to be the expected behaviour given the spec section for location.hash:

If the given value is the empty string, set copyURL's fragment to null.

So not sure if the "navigate" algorithm spec should be updated to take into account null fragments, or if there's another bug in our code that should make us arrive with an url fragment (which doesn't seem to be the case, but I haven't looked too deeply at it).

---

Comments from Reviewable

[jdm]

I've filed whatwg/html#1177 about this.

[bors-servo]

☔ The latest upstream changes (presumably #11048) made this pull request unmergeable. Please resolve the merge conflicts.

[emilio]

I think this should probably be rebased and landed while we wait for input in whatwg/html, there are quite a few pages affected.

What do you think @jdm? I can do the rebase if you're busy btw :)

[jdm]

I am inclined to agree, with a comment that links to the whatwg issue. If you could do the rebase, that would be swell!

[emilio]

Rebased in #11321