Support plain number-typed properties in geckolib #10957

heycam · 2016-05-02T00:29:38Z

r? @bholley

This change is

highfive · 2016-05-02T00:29:41Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/longhand/effects.mako.rs, components/style/properties/data.py, components/style/values.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/properties/longhand/svg_inherited.mako.rs, components/style/properties/longhand/svg.mako.rs, components/style/properties/longhand/xul.mako.rs

highfive · 2016-05-02T00:29:42Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

bholley · 2016-05-02T19:08:54Z

components/style/values.rs

+        fn parse_with_minimum(input: &mut Parser, min: CSSFloat) -> Result<Number, ()> {
+            match parse_number(input) {
+                Ok(value) if value < min => Err(()),
+                value => value.map(Number),


Using a newtype as a function in this way seems a bit weird, but maybe it's a totally acceptable pattern. Can you verify that this is acceptable Rust? (No need to block landing on it)

There are a couple of other similar uses in this file – mapping to Au and Percentage – and a bunch more mapping to enum constructors, which is not so different.

bholley · 2016-05-02T19:09:44Z

Nice!

@bors-servo r=bholley

Don't forget to update the spreadsheet!

bors-servo · 2016-05-02T19:09:46Z

📌 Commit 22513a6 has been approved by bholley

bholley · 2016-05-02T19:10:33Z

Oh wait, tidy problem. @bor-servo r-

bholley · 2016-05-02T19:10:52Z

@bors-servo delegate+

I'd recommend running ./mach test-tidy before pushing PRs.

bors-servo · 2016-05-02T19:10:53Z

✌️ @heycam can now approve this pull request

bors-servo · 2016-05-02T19:45:37Z

⌛ Testing commit 22513a6 with merge 7528ecb...


        Auto merge of #10957 - heycam:number, r=bholley

@bholley

Support plain number-typed properties in geckolib r? @bholley  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10957)

bors-servo · 2016-05-02T20:00:23Z

💔 Test failed - linux-dev


        Generate geckolib setters for properties with simple predefined types.


        Factor out opacity property to use an Opacity type.


        Support {fill,stroke,stop,flood}-opacity in geckolib.


        Add a predefined Number type.


        Support flex-{grow,shrink}, stroke-miterlimit and -moz-box-flex in ge…

…ckolib.

heycam · 2016-05-03T04:55:41Z

@bors-servo r=bholley

bors-servo · 2016-05-03T04:55:42Z

📌 Commit 53649b1 has been approved by bholley

bors-servo · 2016-05-03T04:58:18Z

⌛ Testing commit 53649b1 with merge ddada69...


        Auto merge of #10957 - heycam:number, r=bholley

@bholley

Support plain number-typed properties in geckolib r? @bholley  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10957)

bors-servo · 2016-05-03T05:57:50Z

💔 Test failed - linux-rel

highfive · 2016-05-03T05:57:54Z

  ▶ FAIL [expected PASS] /_mozilla/css/iframe/mozbrowser_navigation.html
  └   → /_mozilla/css/iframe/mozbrowser_navigation.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
/_mozilla/css/iframe/mozbrowser_navigation_ref.html 8250706e506ad24231cc23be315b9b868387c598
Testing d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c == 8250706e506ad24231cc23be315b9b868387c598

heycam · 2016-05-03T06:10:18Z

@bors-servo retry

#10924

bors-servo · 2016-05-03T06:54:50Z

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

bors-servo · 2016-05-03T07:40:48Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows


        Auto merge of #10959 - heycam:color, r=bholley

@bholley

Support color-typed properties in geckolib This is on top of #10957 though I'm not sure how to make that PR's commits not appear in this one. r? @bholley  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10959)


        Auto merge of #10959 - heycam:color, r=bholley

@bholley

Support color-typed properties in geckolib This is on top of #10957 though I'm not sure how to make that PR's commits not appear in this one. r? @bholley  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10959)


        Auto merge of #10959 - heycam:color, r=bholley

@bholley

Support color-typed properties in geckolib This is on top of #10957 though I'm not sure how to make that PR's commits not appear in this one. r? @bholley  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10959)


        servo: Merge #10959 - Support color-typed properties in geckolib (fro…

…m heycam:color); r=bholley This is on top of servo/servo#10957 though I'm not sure how to make that PR's commits not appear in this one. r? bholley Source-Repo: https://github.com/servo/servo Source-Revision: 1a1ea30f8c36a5dd01717fbf2294707f5d78c377 UltraBlame original commit: 36634609ea90b79d84ab07a959df7644a8f40d37


        servo: Merge #10959 - Support color-typed properties in geckolib (fro…

…m heycam:color); r=bholley This is on top of servo/servo#10957 though I'm not sure how to make that PR's commits not appear in this one. r? bholley Source-Repo: https://github.com/servo/servo Source-Revision: 1a1ea30f8c36a5dd01717fbf2294707f5d78c377 UltraBlame original commit: 36634609ea90b79d84ab07a959df7644a8f40d37


        servo: Merge #10959 - Support color-typed properties in geckolib (fro…

…m heycam:color); r=bholley This is on top of servo/servo#10957 though I'm not sure how to make that PR's commits not appear in this one. r? bholley Source-Repo: https://github.com/servo/servo Source-Revision: 1a1ea30f8c36a5dd01717fbf2294707f5d78c377 UltraBlame original commit: 36634609ea90b79d84ab07a959df7644a8f40d37

highfive assigned Ms2ger May 2, 2016

highfive added the S-awaiting-review label May 2, 2016

heycam force-pushed the heycam:number branch from 47c2a7e to 22513a6 May 2, 2016

heycam mentioned this pull request May 2, 2016

Support color-typed properties in geckolib #10959

Merged

bholley reviewed May 2, 2016
View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels May 2, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 2, 2016

heycam force-pushed the heycam:number branch from 22513a6 to 53649b1 May 2, 2016

highfive added S-awaiting-review and removed S-tests-failed labels May 2, 2016

heycam added 5 commits May 1, 2016

Generate geckolib setters for properties with simple predefined types.

d69763b

Factor out opacity property to use an Opacity type.

0f2dc53

Support {fill,stroke,stop,flood}-opacity in geckolib.

d71e5c8

Add a predefined Number type.

3255bb8

Support flex-{grow,shrink}, stroke-miterlimit and -moz-box-flex in ge…

Loading status checks…

53649b1

…ckolib.

highfive removed the S-awaiting-review label May 3, 2016

highfive added the S-awaiting-merge label May 3, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 3, 2016

KiChjang assigned bholley and unassigned Ms2ger May 3, 2016

bors-servo merged commit 53649b1 into servo:master May 3, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 3, 2016

heycam deleted the heycam:number branch May 25, 2016

servo / servo

Support plain number-typed properties in geckolib #10957

Support plain number-typed properties in geckolib #10957

heycam commented May 2, 2016 •

edited by larsbergstrom

highfive commented May 2, 2016

highfive commented May 2, 2016

This comment has been minimized.

This comment has been minimized.

bholley commented May 2, 2016

bors-servo commented May 2, 2016

bholley commented May 2, 2016

bholley commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

heycam commented May 3, 2016

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

highfive commented May 3, 2016

heycam commented May 3, 2016 •

edited by KiChjang

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

servo / servo

Join GitHub today

Support plain number-typed properties in geckolib #10957

Support plain number-typed properties in geckolib #10957

Conversation

heycam commented May 2, 2016 • edited by larsbergstrom

highfive commented May 2, 2016

highfive commented May 2, 2016

This comment has been minimized.

bholley May 2, 2016

This comment has been minimized.

heycam May 2, 2016

bholley commented May 2, 2016

bors-servo commented May 2, 2016

bholley commented May 2, 2016

bholley commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

heycam commented May 3, 2016

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

highfive commented May 3, 2016

heycam commented May 3, 2016 • edited by KiChjang

bors-servo commented May 3, 2016

bors-servo commented May 3, 2016

heycam commented May 2, 2016 •

edited by larsbergstrom

heycam commented May 3, 2016 •

edited by KiChjang