Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused mut warning #10979

Merged
merged 1 commit into from May 3, 2016
Merged

Fix unused mut warning #10979

merged 1 commit into from May 3, 2016

Conversation

@bstrie
Copy link
Contributor

bstrie commented May 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@bstrie
Fix unused mut warning
Loading status checks…
08987c6
@highfive
Copy link

highfive commented May 3, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@highfive
Copy link

highfive commented May 3, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified.Please consider adding a test!
@frewsxcv
Copy link
Member

frewsxcv commented May 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

📌 Commit 08987c6 has been approved by frewsxcv
@KiChjang KiChjang assigned frewsxcv and unassigned jdm May 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

⌛ Testing commit 08987c6 with merge 61ec715...
bors-servo added a commit that referenced this pull request May 3, 2016
@bors-servo
Auto merge of #10979 - bstrie:mutwarn, r=frewsxcv
Loading status checks…
61ec715 
Fix unused mut warning

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10979)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented May 3, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@frewsxcv
Copy link
Member

frewsxcv commented May 3, 2016

@bors-servo retry

#10473
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

⌛ Testing commit 08987c6 with merge 03acded...
bors-servo added a commit that referenced this pull request May 3, 2016
@bors-servo
Auto merge of #10979 - bstrie:mutwarn, r=frewsxcv
Loading status checks…
03acded 
Fix unused mut warning

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10979)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

💔 Test failed - windows
@KiChjang
Copy link
Member

KiChjang commented May 3, 2016

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

⌛ Testing commit 08987c6 with merge 8e2cb95...
bors-servo added a commit that referenced this pull request May 3, 2016
@bors-servo
Auto merge of #10979 - bstrie:mutwarn, r=frewsxcv
Loading status checks…
8e2cb95 
Fix unused mut warning

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10979)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 08987c6 into servo:master May 3, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@bstrie @highfive @frewsxcv @bors-servo @KiChjang @jdm
You can’t perform that action at this time.