Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move width and height from Box to Position. #10999

Merged
merged 1 commit into from May 5, 2016

Conversation

@heycam
Copy link
Member

heycam commented May 4, 2016

This helps with style struct alignment between Servo and Gecko.


This change is Reviewable

This helps with style struct alignment between Servo and Gecko.
@highfive

This comment has been minimized.

Copy link

highfive commented May 4, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/properties.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/animation.rs
@highfive

This comment has been minimized.

Copy link

highfive commented May 4, 2016

warning Warning warning

  • These commits modify style and layout code, but no tests are modified.Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member Author

heycam commented May 4, 2016

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented May 4, 2016

@bors-servo r+


Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 4, 2016

📌 Commit 550d780 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2016

⌛️ Testing commit 550d780 with merge 8bc4785...

bors-servo added a commit that referenced this pull request May 5, 2016
Move width and height from Box to Position.

This helps with style struct alignment between Servo and Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10999)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2016

💔 Test failed - linux-rel

@highfive

This comment has been minimized.

Copy link

highfive commented May 5, 2016

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, containerWidthStyle: &#39;400px&#39;, containerHeightStyle: &#39;400px&#39;, placeholderWidthAttr: &#39;50%&#39;, svgViewBoxAttr: &#39;0 0 100 200&#39;, svgWidthAttr: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out
@heycam

This comment has been minimized.

Copy link
Member Author

heycam commented May 5, 2016

1 similar comment
@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented May 5, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2016

⚡️ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

@KiChjang

This comment has been minimized.

Copy link
Member

KiChjang commented May 5, 2016

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2016

✌️ @heycam can now approve this pull request

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 5, 2016

@bors-servo bors-servo merged commit 550d780 into servo:master May 5, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request May 5, 2016
Support most remaining length/percentage/none/auto-taking properties in geckolib

This is on top of #10999 so no need to review 8ae820b.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11001)
<!-- Reviewable:end -->
@heycam heycam deleted the heycam:move-width-height branch May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.