Implement navigation events #11006

cbrewster · 2016-05-04T17:09:50Z

fixes #11005

Events:

PopStateEvent
HashChangeEvent
PageTransitionEvent

This change is

highfive · 2016-05-04T17:09:56Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/webidls/PopStateEvent.webidl, components/script/dom/mod.rs, components/script/dom/popstateevent.rs, components/script/dom/pagetransitionevent.rs, components/script/dom/webidls/PageTransitionEvent.webidl, components/script/dom/hashchangeevent.rs, components/script/dom/webidls/HashChangeEvent.webidl

highfive · 2016-05-04T17:09:57Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified.Please consider adding a test!

cbrewster · 2016-05-04T17:10:06Z

@bors-servo try

bors-servo · 2016-05-04T17:10:10Z

⌛ Trying commit 62deaa3 with merge d109691...


        Auto merge of #11006 - ConnorGBrewster:history_events, r=<try>

Implement navigation events fixes #11005 Events: * `PopStateEvent` * `HashChangeEvent` * `PageTransitionEvent`

bors-servo · 2016-05-04T17:25:15Z

💔 Test failed - linux-dev

highfive · 2016-05-04T18:08:47Z

New code was committed to pull request.

cbrewster · 2016-05-04T18:09:11Z

@bors-servo try

bors-servo · 2016-05-04T18:09:14Z

⌛ Trying commit 86ff936 with merge d9ef8d7...


        Auto merge of #11006 - ConnorGBrewster:history_events, r=<try>

Implement navigation events fixes #11005 Events: * `PopStateEvent` * `HashChangeEvent` * `PageTransitionEvent`  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11006)

bors-servo · 2016-05-04T19:04:43Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-04T19:04:45Z

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/PopStateEvent.html:
  └ PASS [expected FAIL] initPopStateEvent

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, persisted true

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, persisted true

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, empty options

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, empty options

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, missing options

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, missing options

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, persisted:null

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, persisted:null

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, persisted:undefined

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, persisted:undefined

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, bubbles:true

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, bubbles:true

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pageshow event, cancelable:true

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/events.html:
  └ PASS [expected FAIL] Constructing pagehide event, cancelable:true

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface: existence and properties of interface object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface object length

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface object name

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface: existence and properties of i</span><span class="stdout">nterface prototype object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface: existence and properties of interface prototype object&#39;s &#34;constructor&#34; property

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface: attribute state

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent must be primary interface of new PopStateEvent(&#34;popstate&#34;, { data: {} })

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Stringification of new PopStateEvent(&#34;popstate&#34;, { data: {} })

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PopStateEvent interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;state&#34; with the proper type (0)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;type&#34; with the proper type (0)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;target&#34; with the proper type (1)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;currentTarget&#34; with the proper type (2)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;NONE&#34; with the proper type (3)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;CAPTURING_PHASE&#34; with the proper type (4)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;AT_TARGET&#34; with the proper type (5)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;BUBBLING_PHASE&#34; with the proper type (6)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;eventPhase&#34; with the proper type (7)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;stopPropagation&#34; with the proper type (8)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;stopImmediatePropagation&#34; with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;bubbles&#34; with the proper type (10)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;cancelable&#34; with the proper type (11)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;preventDefault&#34; with the proper type (12)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;defaultPrevented&#34; with the proper type (13)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must have own property &#34;isTrusted&#34;

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;timeStamp&#34; with the proper type (15)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: new PopStateEvent(&#34;popstate&#34;, { data: {} }) must inherit property &#34;initEvent&#34; with the proper type (16)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] Event interface: calling initEvent(DOMString,boolean,boolean) on new PopStateEvent(&#34;popstate&#34;, { data: {} }) with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface: existence and properties of interface object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface object length

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface object name

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface: existence and properties of interface prototype object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface: existence and properties of interface prototype object&#39;s &#34;constructor&#34; property

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface: attribute oldURL

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HashChangeEvent interface: attribute newURL

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface: existence and properties of interface object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface object length

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface object name

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface: existence and properties of interface prototype object

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface: existence and properties of interface prototype object&#39;s &#34;constructor&#34; property

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] PageTransitionEvent interface: attribute persisted

  ▶ Unexpected subtest result in /_mozilla/mozilla/interfaces.html:
  │ FAIL [expected PASS] Interfaces exposed on the window
  │   → assert_true: If this is failing: DANGER, are you sure you want to expose the new interface PageTransitionEvent to all webpages as a property on the window? Do not make a change to this file without review from jdm or Ms2ger for that specific change! expected true got false
  │ 
  │ @http://web-platform.test:8000/_mozilla/mozilla/interfaces.html:251:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/_mozilla/mozilla/interfaces.html:245:1

highfive · 2016-05-04T19:23:43Z

New code was committed to pull request.

cbrewster · 2016-05-04T19:25:47Z

This is ready for review!

jdm · 2016-05-04T19:41:09Z

components/script/dom/hashchangeevent.rs

+        ev
+    }
+
+    #[allow(unsafe_code)]


whoops! there should only be on the PopStateEvent due to the webidl any. But I will remove it on the other 2 events.

highfive · 2016-05-04T20:27:24Z

New code was committed to pull request.

highfive · 2016-05-10T21:20:23Z

New code was committed to pull request.

highfive · 2016-05-11T18:42:26Z

New code was committed to pull request.

cbrewster · 2016-05-11T18:43:21Z

Just squashed, that test is passing, I added PageTransitionEvent to the exposed properties list after that test failure.

jdm · 2016-05-11T20:09:44Z

That is the correct thing to do.

jdm · 2016-05-11T20:09:54Z

@bors-servo: r=asajeffrey

bors-servo · 2016-05-11T20:09:55Z

📌 Commit ccd838f has been approved by asajeffrey

bors-servo · 2016-05-12T03:24:07Z

⌛ Testing commit ccd838f with merge 78471d4...


        Auto merge of #11006 - ConnorGBrewster:history_events, r=asajeffrey

Implement navigation events fixes #11005 Events: * `PopStateEvent` * `HashChangeEvent` * `PageTransitionEvent`  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11006)

bors-servo · 2016-05-12T03:53:01Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-12T03:53:03Z

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/PopStateEvent.html:
  └ PASS [expected FAIL] document.createEvent

cbrewster · 2016-05-12T04:05:44Z

I am unsure why that test is failing. It is not marked as expected to fail.

jdm · 2016-05-12T04:06:41Z

http://mxr.mozilla.org/servo/source/tests/wpt/metadata/html/browsers/browsing-the-web/history-traversal/PopStateEvent.html.ini

cbrewster · 2016-05-12T04:09:09Z

@jdm ahh need to rebase my local version


        add popstateevent, hashchangeevent, pagetransitionevent

highfive · 2016-05-12T04:11:57Z

New code was committed to pull request.

asajeffrey · 2016-05-12T13:52:40Z

@bors-servo r+

bors-servo · 2016-05-12T13:52:41Z

📌 Commit 11dd0d7 has been approved by asajeffrey

bors-servo · 2016-05-12T14:27:14Z

⌛ Testing commit 11dd0d7 with merge bca625b...


        Auto merge of #11006 - ConnorGBrewster:history_events, r=asajeffrey

Implement navigation events fixes #11005 Events: * `PopStateEvent` * `HashChangeEvent` * `PageTransitionEvent`  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11006)

bors-servo · 2016-05-12T15:18:00Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned glennw May 4, 2016

highfive added the S-awaiting-review label May 4, 2016

bors-servo added a commit that referenced this pull request May 4, 2016

Auto merge of #11006 - ConnorGBrewster:history_events, r=<try>

Loading status checks…

d109691

Implement navigation events fixes #11005 Events: * `PopStateEvent` * `HashChangeEvent` * `PageTransitionEvent`

cbrewster mentioned this pull request May 4, 2016

History API metabug #10992

Open

18 of 24 tasks complete

highfive added the S-tests-failed label May 4, 2016

cbrewster force-pushed the cbrewster:history_events branch from 62deaa3 to 86ff936 May 4, 2016

highfive removed the S-tests-failed label May 4, 2016

highfive added the S-tests-failed label May 4, 2016

cbrewster force-pushed the cbrewster:history_events branch from 86ff936 to f415af1 May 4, 2016

highfive removed the S-tests-failed label May 4, 2016

jdm reviewed May 4, 2016
View changes

cbrewster force-pushed the cbrewster:history_events branch from b77e0ed to ddf9988 May 10, 2016

highfive assigned jdm and unassigned glennw May 10, 2016

cbrewster unassigned jdm May 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 11, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 12, 2016

add popstateevent, hashchangeevent, pagetransitionevent

Loading status checks…

11dd0d7

cbrewster force-pushed the cbrewster:history_events branch from ccd838f to 11dd0d7 May 12, 2016

highfive added S-awaiting-review and removed S-tests-failed labels May 12, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 12, 2016

bors-servo merged commit 11dd0d7 into servo:master May 12, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 12, 2016

servo / servo

Implement navigation events #11006

Implement navigation events #11006

cbrewster commented May 4, 2016 •

edited by larsbergstrom

highfive commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

bors-servo commented May 4, 2016

bors-servo commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

bors-servo commented May 4, 2016

bors-servo commented May 4, 2016

highfive commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

This comment has been minimized.

This comment has been minimized.

highfive commented May 4, 2016

highfive commented May 10, 2016

highfive commented May 11, 2016

cbrewster commented May 11, 2016

jdm commented May 11, 2016

jdm commented May 11, 2016

bors-servo commented May 11, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

cbrewster commented May 12, 2016

jdm commented May 12, 2016

cbrewster commented May 12, 2016

highfive commented May 12, 2016

asajeffrey commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

servo / servo

Join GitHub today

Implement navigation events #11006

Implement navigation events #11006

Conversation

cbrewster commented May 4, 2016 • edited by larsbergstrom

highfive commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

bors-servo commented May 4, 2016

bors-servo commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

bors-servo commented May 4, 2016

bors-servo commented May 4, 2016

highfive commented May 4, 2016

highfive commented May 4, 2016

cbrewster commented May 4, 2016

This comment has been minimized.

jdm May 4, 2016

This comment has been minimized.

cbrewster May 4, 2016

highfive commented May 4, 2016

highfive commented May 10, 2016

highfive commented May 11, 2016

cbrewster commented May 11, 2016

jdm commented May 11, 2016

jdm commented May 11, 2016

bors-servo commented May 11, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

cbrewster commented May 12, 2016

jdm commented May 12, 2016

cbrewster commented May 12, 2016

highfive commented May 12, 2016

asajeffrey commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

cbrewster commented May 4, 2016 •

edited by larsbergstrom