Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Unblock webrender update #11012

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -469,10 +469,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
.unwrap();
match handle_potential_webgl_error!(self, receiver.recv().unwrap(), WebGLParameter::Invalid) {
WebGLParameter::Int(val) => Int32Value(val),
WebGLParameter::Bool(_) => panic!("Buffer parameter should not be bool"),
WebGLParameter::Float(_) => panic!("Buffer parameter should not be float"),
WebGLParameter::String(_) => panic!("Buffer parameter should not be string"),
WebGLParameter::Invalid => NullValue(),
_ => unreachable!("Invalid WebGL buffer parameter"),
}
}

@@ -495,6 +493,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
rval.ptr
}
WebGLParameter::Invalid => NullValue(),
_ => unreachable!("Invalid WebGL parameter"),
}
}

@@ -1091,9 +1090,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
match handle_potential_webgl_error!(self, program.parameter(param_id), WebGLParameter::Invalid) {
WebGLParameter::Int(val) => Int32Value(val),
WebGLParameter::Bool(val) => BooleanValue(val),
WebGLParameter::String(_) => panic!("Program parameter should not be string"),
WebGLParameter::Float(_) => panic!("Program parameter should not be float"),
WebGLParameter::Invalid => NullValue(),
_ => unreachable!("Invalid WebGL buffer parameter"),
}
} else {
NullValue()
@@ -1111,9 +1109,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
match handle_potential_webgl_error!(self, shader.parameter(param_id), WebGLParameter::Invalid) {
WebGLParameter::Int(val) => Int32Value(val),
WebGLParameter::Bool(val) => BooleanValue(val),
WebGLParameter::String(_) => panic!("Shader parameter should not be string"),
WebGLParameter::Float(_) => panic!("Shader parameter should not be float"),
WebGLParameter::Invalid => NullValue(),
_ => unreachable!("Invalid WebGL shader parameter"),
}
} else {
NullValue()

Some generated files are not rendered by default. Learn more.

Some generated files are not rendered by default. Learn more.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.