Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag names in all user-agent selectors. #11022

Merged
merged 1 commit into from May 9, 2016
Merged

Use tag names in all user-agent selectors. #11022

merged 1 commit into from May 9, 2016

Conversation

@notriddle
Copy link
Contributor

notriddle commented May 4, 2016 •
edited by larsbergstrom

Fixes #11004

This change is Reviewable
resources/user-agent.css Outdated
/*
* FIXME: use `outline: auto;`
*/
a:focus, area:focus { outline: thin dotted; }

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm May 5, 2016

Member

This should cover input and button elements too.
@notriddle
Use tag names in all user-agent selectors.
Loading status checks…
d98431e 
Fixes #11004
@highfive
Copy link

highfive commented May 5, 2016

New code was committed to pull request.
@nox
Copy link
Member

nox commented May 5, 2016

Is there no way to do that differently? Isn't that stylesheet directly taken from the HTML spec? And as far as I know, <link> can also match :link.
@notriddle
Copy link
Contributor Author

notriddle commented May 5, 2016 •
edited

The best long-term fix is to allow style sharing on elements that have non-traversal-selection pseudo-classes. See rust-selectors/src/matching.rs.
@metajack
Copy link
Contributor

metajack commented May 6, 2016

r? @SimonSapin or @pcwalton
@highfive highfive assigned SimonSapin and unassigned KiChjang May 6, 2016
@pcwalton
Copy link
Contributor

pcwalton commented May 6, 2016

Could you file a follow up issue to do this properly? I'm OK with this for now, but I'd like to make sure we don't forget to implement this correctly.
@notriddle
Copy link
Contributor Author

notriddle commented May 7, 2016

#11071
@SimonSapin
Copy link
Member

SimonSapin commented May 9, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

📌 Commit d98431e has been approved by SimonSapin
@SimonSapin SimonSapin mentioned this pull request May 9, 2016
Open
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

⌛ Testing commit d98431e with merge 58a9b31...
bors-servo added a commit that referenced this pull request May 9, 2016
@bors-servo
Auto merge of #11022 - notriddle:master, r=SimonSapin
Loading status checks…
58a9b31 
Use tag names in all user-agent selectors.

Fixes #11004

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11022)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit d98431e into servo:master May 9, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@notriddle @highfive @nox @metajack @pcwalton @SimonSapin @bors-servo @jdm @KiChjang
You can’t perform that action at this time.