Remove BluetoothDevice members #11028

fokinv · 2016-05-05T10:58:39Z

Five of the BluetoothDevice members has been deleted in the spec:
WebBluetoothCG/web-bluetooth@8d148ba

These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.

This change is


        Remove BluetoothDevice members

highfive · 2016-05-05T10:58:44Z

Heads up! This PR modifies the following files:

@KiChjang: components/net_traits/bluetooth_thread.rs, components/net_traits/bluetooth_thread.rs, components/script/dom/webidls/BluetoothDevice.webidl, components/net/bluetooth_thread.rs, components/script/dom/bluetooth.rs, components/script/dom/bluetoothdevice.rs

highfive · 2016-05-05T10:58:45Z

Warning

These commits modify net and script code, but no tests are modified.Please consider adding a test!

jdm · 2016-05-05T13:02:51Z

@bors-servo: r+

bors-servo · 2016-05-05T13:02:53Z

📌 Commit ed92f31 has been approved by jdm

bors-servo · 2016-05-06T01:09:54Z

⌛ Testing commit ed92f31 with merge 232c178...


        Auto merge of #11028 - szeged:webbluetooth, r=jdm

Remove BluetoothDevice members Five of the BluetoothDevice members has been deleted in the spec: WebBluetoothCG/web-bluetooth@8d148ba These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)

bors-servo · 2016-05-06T01:09:56Z

💔 Test failed - mac-dev-unit

jdm · 2016-05-06T14:30:18Z

@bors-servo: retry

servo/saltfs#349

bors-servo · 2016-05-06T14:37:04Z

⌛ Testing commit ed92f31 with merge b30db53...


        Auto merge of #11028 - szeged:webbluetooth, r=jdm

Remove BluetoothDevice members Five of the BluetoothDevice members has been deleted in the spec: WebBluetoothCG/web-bluetooth@8d148ba These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)

bors-servo · 2016-05-06T15:10:13Z

💔 Test failed - windows

jdm · 2016-05-06T16:59:45Z

@bors-servo: retry

infra

bors-servo · 2016-05-06T17:05:42Z

⌛ Testing commit ed92f31 with merge abe539a...


        Auto merge of #11028 - szeged:webbluetooth, r=jdm

Remove BluetoothDevice members Five of the BluetoothDevice members has been deleted in the spec: WebBluetoothCG/web-bluetooth@8d148ba These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)

bors-servo · 2016-05-06T17:07:36Z

💔 Test failed - windows

bors-servo · 2016-05-06T19:39:49Z

⌛ Testing commit ed92f31 with merge cd3adf3...


        Auto merge of #11028 - szeged:webbluetooth, r=jdm

Remove BluetoothDevice members Five of the BluetoothDevice members has been deleted in the spec: WebBluetoothCG/web-bluetooth@8d148ba These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)

bors-servo · 2016-05-06T20:42:29Z

💔 Test failed - mac-rel-css

highfive · 2016-05-06T20:42:33Z

  ▶ CRASH [expected PASS] /css-transforms-1_dev/html/svg-translate-abs-unit-combinations-004.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x108a30958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x108a36c35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x108a3684e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x108189b62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x108a1e128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x108a1fa5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x108a2fc27 - rust_begin_unwind
  │    8:        0x108a5e9f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x108a5ecec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x107c6aa90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x107c6d739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x108a2fbbb - __rust_try
  │   13:        0x108a2fb43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x107c6da4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x108a35cb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

  ▶ CRASH [expected PASS] /css-transforms-1_dev/html/svg-translate-abs-unit-combinations-003.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x110a79958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x110a7fc35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x110a7f84e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1101d2b62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x110a67128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x110a68a5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x110a78c27 - rust_begin_unwind
  │    8:        0x110aa79f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x110aa7cec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x10fcb3a90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x10fcb6739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x110a78bbb - __rust_try
  │   13:        0x110a78b43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10fcb6a4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x110a7ecb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

  ▶ CRASH [expected PASS] /css21_dev/html4/border-left-color-106.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x10a3df958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10a3e5c35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10a3e584e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x109b38b62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x10a3cd128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10a3cea5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10a3dec27 - rust_begin_unwind
  │    8:        0x10a40d9f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x10a40dcec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x109619a90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x10961c739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x10a3debbb - __rust_try
  │   13:        0x10a3deb43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10961ca4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x10a3e4cb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

  ▶ CRASH [expected PASS] /css21_dev/html4/border-right-color-055.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x104c95958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x104c9bc35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x104c9b84e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1043eeb62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x104c83128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x104c84a5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x104c94c27 - rust_begin_unwind
  │    8:        0x104cc39f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x104cc3cec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x103ecfa90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x103ed2739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x104c94bbb - __rust_try
  │   13:        0x104c94b43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x103ed2a4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:    </span><span class="stdout">    0x104c9acb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

  ▶ CRASH [expected FAIL] /css21_dev/html4/run-in-run-in-between-003.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x10f051958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10f057c35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10f05784e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10e7aab62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x10f03f128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10f040a5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10f050c27 - rust_begin_unwind
  │    8:        0x10f07f9f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x10f07fcec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x10e28ba90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x10e28e739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x10f050bbb - __rust_try
  │   13:        0x10f050b43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10e28ea4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x10f056cb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

larsbergstrom · 2016-05-06T20:43:40Z

@bors-servo retry

this should have gone after #11052

jdm · 2016-05-06T21:49:59Z

Those panics are all unrelated to #11052 and should be filed.

bors-servo · 2016-05-06T21:51:37Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, windows are reusable. Rebuilding only mac-rel-css, mac-rel-wpt...

bors-servo · 2016-05-06T22:29:29Z

💔 Test failed - mac-rel-css

highfive · 2016-05-06T22:29:30Z

  ▶ CRASH [expected PASS] /css21_dev/html4/position-relative-032.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x109d0a998 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x109d10c75 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x109d1088e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x109463ba2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x109cf8168 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x109cf9a9e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x109d09c67 - rust_begin_unwind
  �</span><span class="stdout">��    8:        0x109d38a30 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x109d38d2c - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x108f44ad0 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x108f47779 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x109d09bfb - __rust_try
  │   13:        0x109d09b83 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x108f47a8a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x109d0fcf8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff86bcf059 - _pthread_body
  │   17:     0x7fff86bcefd6 - _pthread_start
  └ thread panicked while panicking. aborting.

mbrubeck · 2016-05-06T23:20:47Z

@bors-servo retry

#11059

bors-servo · 2016-05-07T00:07:56Z

⌛ Testing commit ed92f31 with merge a153e20...


        Auto merge of #11028 - szeged:webbluetooth, r=jdm

Remove BluetoothDevice members Five of the BluetoothDevice members has been deleted in the spec: WebBluetoothCG/web-bluetooth@8d148ba These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)

bors-servo · 2016-05-07T00:49:47Z

💔 Test failed - mac-rel-css

highfive · 2016-05-07T00:49:49Z

  ▶ CRASH [expected FAIL] /css21_dev/html4/first-letter-punctuation-086.htm
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread &#39;ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }&#39; panicked at &#39;called `Option::unwrap()` on a `None` value&#39;, ../src/libcore/option.rs:325
  │ stack backtrace:
  │    1:        0x102ae5958 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x102aebc35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x102aeb84e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10223eb62 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::heda6930908f06acc
  │    5:        0x102ad3128 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x102ad4a5e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x102ae4c27 - rust_begin_unwind
  │    8:        0x102b139f0 - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:        0x102b13cec - core::panicking::panic::h4bb1497076d04ab9
  │   10:        0x101d1fa90 - _&lt;script_thread..ScriptMemoryFailsafe&lt;&#39;a&gt; as core..ops..Drop&gt;::drop::h0ba2c08a14df10c8
  │   11:        0x101d22739 - std::sys_common::unwind::try::try_fn::hd12b2d76c81a0e30
  │   12:        0x102ae4bbb - __rust_try
  │   13:        0x102ae4b43 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x101d22a4a - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::he24f36d07ed1c7fd
  │   15:        0x102aeacb8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  └ thread panicked while panicking. aborting.

jdm · 2016-05-07T02:39:00Z

@bors-servo: retry
#11059

bors-servo · 2016-05-07T03:26:05Z

💣 Failed to start rebuilding: 502 Bad Gateway

bors-servo · 2016-05-07T03:26:09Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css, windows...

bors-servo · 2016-05-07T04:53:25Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

Remove BluetoothDevice members

Loading status checks…

ed92f31

highfive assigned nox May 5, 2016

highfive added the S-awaiting-review label May 5, 2016

highfive assigned jdm and unassigned nox May 5, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 5, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 6, 2016

highfive added the S-tests-failed label May 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 7, 2016

highfive removed the S-awaiting-merge label May 7, 2016

highfive added the S-tests-failed label May 7, 2016

bors-servo merged commit ed92f31 into servo:master May 7, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 7, 2016

dati91 deleted the szeged:webbluetooth branch May 30, 2016

servo / servo

Remove BluetoothDevice members #11028

Remove BluetoothDevice members #11028

fokinv commented May 5, 2016 •

edited by larsbergstrom

highfive commented May 5, 2016

highfive commented May 5, 2016

jdm commented May 5, 2016

bors-servo commented May 5, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

highfive commented May 6, 2016

larsbergstrom commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

highfive commented May 6, 2016

mbrubeck commented May 6, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

highfive commented May 7, 2016

jdm commented May 7, 2016 •

edited by KiChjang

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

servo / servo

Join GitHub today

Remove BluetoothDevice members #11028

Remove BluetoothDevice members #11028

Conversation

fokinv commented May 5, 2016 • edited by larsbergstrom

highfive commented May 5, 2016

highfive commented May 5, 2016

jdm commented May 5, 2016

bors-servo commented May 5, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

highfive commented May 6, 2016

larsbergstrom commented May 6, 2016

jdm commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

highfive commented May 6, 2016

mbrubeck commented May 6, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

highfive commented May 7, 2016

jdm commented May 7, 2016 • edited by KiChjang

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

fokinv commented May 5, 2016 •

edited by larsbergstrom

jdm commented May 7, 2016 •

edited by KiChjang