Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build warning in compositor.rs #11042

Merged
merged 1 commit into from May 6, 2016
Merged

Fix a build warning in compositor.rs #11042

merged 1 commit into from May 6, 2016

Conversation

@fabricedesre
Copy link
Contributor

fabricedesre commented May 6, 2016 •
edited by larsbergstrom

Stops the compiler complaining about root_pipeline being an unused variable.

This change is Reviewable
@fabricedesre
Fix a build warning in compositor.rs
Loading status checks…
8489b30
@metajack
Copy link
Contributor

metajack commented May 6, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

📌 Commit 8489b30 has been approved by metajack
@highfive highfive assigned metajack and unassigned nox May 6, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

⌛ Testing commit 8489b30 with merge adb15a6...
bors-servo added a commit that referenced this pull request May 6, 2016
@bors-servo
Auto merge of #11042 - fabricedesre:compositing-warning, r=metajack
Loading status checks…
adb15a6 
Fix a build warning in compositor.rs

Stops the compiler complaining about `root_pipeline` being an unused variable.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented May 6, 2016 

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, containerHeightStyle: &#39;400px&#39;, placeholderWidthAttr: &#39;50%&#39;, svgViewBoxAttr: &#39;0 0 100 200&#39;, svgWidthAttr: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, placeholderWidthAttr: &#39;50%&#39;, placeholderHeightAttr: &#39;100%&#39;, svgViewBoxAttr: &#39;0 0 100 200&#39;, svgWidthAttr: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 6, 2016 •
edited by jdm

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

⌛ Testing commit 8489b30 with merge 29ed650...
bors-servo added a commit that referenced this pull request May 6, 2016
@bors-servo
Auto merge of #11042 - fabricedesre:compositing-warning, r=metajack
Loading status checks…
29ed650 
Fix a build warning in compositor.rs

Stops the compiler complaining about `root_pipeline` being an unused variable.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 8489b30 into servo:master May 6, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@fabricedesre fabricedesre deleted the fabricedesre:compositing-warning branch May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@fabricedesre @metajack @bors-servo @highfive @larsbergstrom @nox
You can’t perform that action at this time.