Added webdriver delete session command.

[asajeffrey]

Delete session is needed by the web platform test webdriver/navigation.py.

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @jgraham: components/webdriver_server/lib.rs

[jgraham]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 305 [r1] (raw file):
Does exiting race sending the response here?

---

Comments from Reviewable

[asajeffrey]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 305 [r1] (raw file):
Indeed it does. I wasn't sure if we should be exiting now, or if there'd be a later exit command. Servo doesn;'t really support sessions...

---

Comments from Reviewable

[jgraham]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 305 [r1] (raw file):
So I think what you want to do is add the Exit message in the fn delete_session in WebDriverHandler at the bottom of the file. That at least makes it my problem if there is a race ;)

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[asajeffrey]

Rebased and responded to review comment.

Previously, highfive wrote…

New code was committed to pull request.

---

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 305 [r1] (raw file):

Previously, jgraham wrote…

So I think what you want to do is add the Exit message in the fn delete_session in WebDriverHandler at the bottom of the file. That at least makes it my problem if there is a race ;)

Done.

---

Comments from Reviewable

[jgraham]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 320 [r2] (raw file):

    fn handle_get(&self, parameters: &GetParameters) -> WebDriverResult<WebDriverResponse> {
        let url = Url::parse(&parameters.url[..]).or(Url::parse("about:blank")).unwrap();

I think I have steered the working group towards making this an error. Just need to update the spec/tests.

---

Comments from Reviewable

[asajeffrey]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/webdriver_server/lib.rs, line 320 [r2] (raw file):

Previously, jgraham wrote…

I think I have steered the working group towards making this an error. Just need to update the spec/tests.

OK, we can hold off on making this change until the spec has settled down.

---

Comments from Reviewable

[highfive]

New code was committed to pull request.

[jgraham]

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[jgraham]

@bors-servo: r+

[bors-servo]

📌 Commit bbf9eca has been approved by jgraham

[bors-servo]

⌛ Testing commit bbf9eca with merge 0c673ef...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows