'closeevent' argument for Document::createEvent #11051

mrmiywj · 2016-05-06T11:17:56Z

Add "close event" argument for Document::createEvent
Fixes #10737

This change is

highfive · 2016-05-06T11:18:01Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

highfive · 2016-05-06T11:18:02Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/document.rs, components/script/dom/closeevent.rs

Ms2ger · 2016-05-06T11:41:05Z

Thanks!

@bors-servo r+

bors-servo · 2016-05-06T11:41:07Z

📌 Commit efeddfb has been approved by Ms2ger

Ms2ger · 2016-05-06T11:53:00Z

@bors-servo r-

./mach test-tidy reports

./components/script/dom/document.rs:42: use statement is not in alphabetical order
    expected: dom::errorevent::ErrorEvent
    found: dom::closeevent::CloseEvent

highfive · 2016-05-06T11:58:01Z

New code was committed to pull request.

Ms2ger · 2016-05-06T12:01:01Z

@bors-servo r+

Thanks again

bors-servo · 2016-05-06T12:01:02Z

📌 Commit 77a0913 has been approved by Ms2ger

bors-servo · 2016-05-06T17:07:38Z

⌛ Testing commit 77a0913 with merge bb2d56c...


        Auto merge of #11051 - mrmiywj:closeevent-argument, r=Ms2ger

'closeevent' argument for Document::createEvent Add "close event" argument for Document::createEvent Fixes #10737  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11051)

bors-servo · 2016-05-06T17:09:32Z

💔 Test failed - windows

mbrubeck · 2016-05-06T17:57:53Z

@bors-servo retry

servo/saltfs#363

bors-servo · 2016-05-06T18:49:20Z

⌛ Testing commit 77a0913 with merge 05268a8...

bors-servo · 2016-05-06T18:51:10Z

💔 Test failed - windows

larsbergstrom · 2016-05-06T19:40:18Z

@bors-servo retry

servo/saltfs#365

bors-servo · 2016-05-07T07:41:16Z

⌛ Testing commit 77a0913 with merge 9509da3...


        Auto merge of #11051 - mrmiywj:closeevent-argument, r=Ms2ger

'closeevent' argument for Document::createEvent Add "close event" argument for Document::createEvent Fixes #10737  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11051)

bors-servo · 2016-05-07T08:23:30Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-07T08:23:32Z

  ▶ Unexpected subtest result in /websockets/interfaces/CloseEvent/historical.html:
  │ FAIL [expected PASS] createEvent(&#34;CloseEvent&#34;)
  │   → assert_throws: function &#34;function () {
    document.createEvent(&#34;CloseEvent&#34;)
  }&#34; did not throw
  │ 
  │ @http://web-platform.test:8000/websockets/interfaces/CloseEvent/historical.html:2:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/websockets/interfaces/CloseEvent/historical.html:1:1

Ms2ger · 2016-05-07T21:25:18Z

You can remove that part of tests/wpt/web-platform-tests/websockets/interfaces/CloseEvent/historical.html.

Ms2ger · 2016-05-07T21:43:51Z

Or make a change similar to web-platform-tests/wpt#2964


        'closeevent' argument for Document::createEvent

fix alphabetical order delete unused tests

highfive · 2016-05-08T06:40:31Z

New code was committed to pull request.

mrmiywj · 2016-05-08T06:41:19Z

cc @Ms2ger

Ms2ger · 2016-05-09T07:48:38Z

Thanks!

@bors-servo r+

bors-servo · 2016-05-09T07:48:40Z

📌 Commit dfaad2d has been approved by Ms2ger

bors-servo · 2016-05-09T07:48:42Z

⌛ Testing commit dfaad2d with merge a76db9a...


        Auto merge of #11051 - mrmiywj:closeevent-argument, r=Ms2ger

'closeevent' argument for Document::createEvent Add "close event" argument for Document::createEvent Fixes #10737  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11051)

bors-servo · 2016-05-09T08:37:07Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned larsbergstrom May 6, 2016

highfive added the S-awaiting-review label May 6, 2016

highfive assigned Ms2ger and unassigned larsbergstrom May 6, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 6, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels May 6, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 6, 2016

highfive removed the S-awaiting-merge label May 6, 2016

highfive added the S-tests-failed label May 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 7, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 7, 2016

'closeevent' argument for Document::createEvent

Loading status checks…

dfaad2d

fix alphabetical order delete unused tests

highfive added S-awaiting-review and removed S-tests-failed labels May 8, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 9, 2016

bors-servo merged commit dfaad2d into servo:master May 9, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 9, 2016

servo / servo

'closeevent' argument for Document::createEvent #11051

'closeevent' argument for Document::createEvent #11051

mrmiywj commented May 6, 2016 •

edited by Ms2ger

highfive commented May 6, 2016

highfive commented May 6, 2016

Ms2ger commented May 6, 2016

bors-servo commented May 6, 2016

Ms2ger commented May 6, 2016

highfive commented May 6, 2016

Ms2ger commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

mbrubeck commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

larsbergstrom commented May 6, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

highfive commented May 7, 2016

Ms2ger commented May 7, 2016

Ms2ger commented May 7, 2016

highfive commented May 8, 2016

mrmiywj commented May 8, 2016

Ms2ger commented May 9, 2016

bors-servo commented May 9, 2016

bors-servo commented May 9, 2016

bors-servo commented May 9, 2016

servo / servo

Join GitHub today

'closeevent' argument for Document::createEvent #11051

'closeevent' argument for Document::createEvent #11051

Conversation

mrmiywj commented May 6, 2016 • edited by Ms2ger

highfive commented May 6, 2016

highfive commented May 6, 2016

Ms2ger commented May 6, 2016

bors-servo commented May 6, 2016

Ms2ger commented May 6, 2016

highfive commented May 6, 2016

Ms2ger commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

mbrubeck commented May 6, 2016

bors-servo commented May 6, 2016

bors-servo commented May 6, 2016

larsbergstrom commented May 6, 2016

bors-servo commented May 7, 2016

bors-servo commented May 7, 2016

highfive commented May 7, 2016

Ms2ger commented May 7, 2016

Ms2ger commented May 7, 2016

highfive commented May 8, 2016

mrmiywj commented May 8, 2016

Ms2ger commented May 9, 2016

bors-servo commented May 9, 2016

bors-servo commented May 9, 2016

bors-servo commented May 9, 2016

mrmiywj commented May 6, 2016 •

edited by Ms2ger