Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upuse onload in iframe test #11053
Merged
use onload in iframe test #11053
Conversation
the iframe test is implemented using setTimeout function Since the iframe already implement load event, replacing timeout function with load event.
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
May 6, 2016
use onload in iframe test the iframe test is implemented using setTimeout function Since the iframe already implement load event, replacing timeout function with load event. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11053) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 6, 2016
use onload in iframe test the iframe test is implemented using setTimeout function Since the iframe already implement load event, replacing timeout function with load event. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11053) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 7, 2016
use onload in iframe test the iframe test is implemented using setTimeout function Since the iframe already implement load event, replacing timeout function with load event. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11053) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yodalee commentedMay 6, 2016
•
edited by larsbergstrom
#11036
the iframe test is implemented using setTimeout function
Since the iframe already implement load event, replacing
timeout function with load event.
This change is