Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded uniform matrix functions (fixes #10671) #11065
Closed
+3,853
−1,536
Conversation
highfive
commented
May 7, 2016
highfive
commented
May 7, 2016
|
|
|
Just a note: Running http://mdn.github.io/webgl-examples/tutorial/sample6/ locally on Chrome is much smoother than running it on servo, and CPU usage on servo is considerably higher too (10% with Chrome on all CPUs, ~40% with servo). It's not low FPS per se, it just hangs from time to time when using webrender. Without webrender, the FPS are stable albeit lower (I guesstimate 3 FPS) and the CPU usage is ~70%. |
|
@autrilla I suggest opening a new bug for that issue. |
highfive
commented
May 7, 2016
|
New code was committed to pull request. |
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
May 7, 2016
Added uniform matrix functions (fixes #10671) r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11065) <!-- Reviewable:end -->
|
|
highfive
commented
May 7, 2016
|
|
I'll update the test expectations, and look at what's wrong with those failing tests |
|
This looks good to me @autrilla :) Regarding the tests, don't fear marking any new subtest that looks like |
|
Doing another try run to be if those no-longer-timeout are deterministic. @bors-servo: r+ |
|
|
|
whoops, @bors-servo: r- clean try |
highfive
commented
May 7, 2016
|
New code was committed to pull request. |
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
May 8, 2016
Added uniform matrix functions (fixes #10671) r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11065) <!-- Reviewable:end -->
|
|
highfive
commented
May 8, 2016
|
highfive
commented
May 8, 2016
|
New code was committed to pull request. |
|
Why is |
|
|
|
What's the status of this? |
|
@KiChjang there were unrelated failing tests and also some related tests failing, iirc. |
|
@autrilla Can you rebase to recent master? I'll make a try run and see if it still persists. |
|
Okay, it looks like something went wrong with your rebase. The first commit you have on this tree has over 3,000 line additions... |
|
@KiChjang yes, gonk was removed from ports, so there's a huge cargo.lock there, and also some other cargo.locks. I'll get that fixed asap |
|
|
|
@autrilla Is this still being worked on? |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
autrilla commentedMay 7, 2016
•
edited by larsbergstrom
r? @emilio
This change is