Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse the new style system #1109
Use the new style system #1109
Conversation
Credits to:
Deokjin Kim
Ilyong Cho
Jaeman Park
Junyoung Cho
Ryan Choi
Sangeun Kim
Yongjin Kim
Youngmin Yoo
Youngsoo Son
|
this can be a good starting point to transit new css. thanks all |
| @@ -356,6 +359,7 @@ fn parse_qualified_name(iter: &mut Iter, allow_universal: bool, namespaces: &Nam | |||
| } | |||
| }, | |||
| Some(&Delim('|')) => explicit_namespace(iter, allow_universal, Some(~"")), | |||
| Some(&IDHash(*)) => default_namespace(namespaces, None), | |||
This comment has been minimized.
This comment has been minimized.
SimonSapin
Oct 23, 2013
Member
This seems wrong: an ID selector would be parsed as an universal selector?
This comment has been minimized.
This comment has been minimized.
SimonSapin
Oct 23, 2013
Member
Apparently this is a work-around for a larger bug in selector parsing. Let’s take this, and I’ll work on the underlying bug next.
| Some(&Comma) => (), | ||
| Some(&Comma) => { | ||
| iter.next(); | ||
| } |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Oct 23, 2013
Member
I don’t understand this. Shouldn’t the peeked comma be consumed so that it’s not part of the next selector?
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented on b243191
Oct 23, 2013
|
This looks good to me except for the changes in |
This comment has been minimized.
This comment has been minimized.
SimonSapin
replied
Oct 23, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
metajack
replied
Oct 23, 2013
|
r=SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
saw approval from SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
merging sanxiyn/servo/new-style = b243191 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 9b25df1 |
Regressions are: * Incremental layout is broken * `:link` is broken * Source URL is not passed to CSS parser * `text-decoration` propagation for block containers establishing an inline formatting context is not handled This also does not remove NetSurf libcss from the build. That can be done in a followup. This was a team effort. Credits to Deokjin Kim, Ilyong Cho, Jaeman Park, Junyoung Cho, Ryan Choi, Sangeun Kim, Yongjin Kim, Youngmin Yoo, Youngsoo Son.
bors-servo
merged commit b243191
into
servo:master
I have no idea how to test it, but this code builds and is close enough to what it was befor servo#1109. Review much needed.
I think I fixed it in #1112, but I don’t know how to test it. Could you take a look?
Right now the parser does not parse anything that involves URLs. When it does, we’ll need to make sure the base URL is available. We’re using
I don’t understand what this means. What part of the code is responsible? |
Ensure that just reading a manifest file doesn't require us to be in a g...
sanxiyn commentedOct 23, 2013
Regressions are:
:linkis brokentext-decorationpropagation for block containers establishing an inline formatting context is not handledThis also does not remove NetSurf libcss from the build. That can be done in a followup.
This was a team effort. Credits to Deokjin Kim, Ilyong Cho, Jaeman Park, Junyoung Cho, Ryan Choi, Sangeun Kim, Yongjin Kim, Youngmin Yoo, Youngsoo Son.