Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some code from ServoThreadSafeLayoutNode::text_content into script. #11092

Merged
merged 1 commit into from May 9, 2016
Merged

Move some code from ServoThreadSafeLayoutNode::text_content into script. #11092

merged 1 commit into from May 9, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 9, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Move some code from ServoThreadSafeLayoutNode::text_content into script.
Loading status checks…
a5be5a8
@highfive
Copy link

highfive commented May 9, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented May 9, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented May 9, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

📌 Commit a5be5a8 has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang May 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

⌛ Testing commit a5be5a8 with merge 55cc1b6...
bors-servo added a commit that referenced this pull request May 9, 2016
@bors-servo
Auto merge of #11092 - Ms2ger:text_content, r=jdm
55cc1b6 
Move some code from ServoThreadSafeLayoutNode::text_content into script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11092)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented May 9, 2016 

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/detached-container-001.htm:
  │ FAIL [expected PASS] transition within detached container / values
  │   → assert_equals: no intermediate values expected 2 but got 1
  │ 
  │ .cases.values.done@http://web-platform.test:8000/css-transitions-1_dev/html/detached-container-001.htm:69:29
  │ runLoop/&lt;/&lt;/&lt;/&lt;@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:121:26
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1226:20
  │ runLoop/&lt;/&lt;/&lt;@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:120:21
  │ runLoop/&lt;/&lt;@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:119:17
  └ runLoop/&lt;@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:117:13
@jdm
Copy link
Member

jdm commented May 9, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

⌛ Testing commit a5be5a8 with merge d529d7e...
bors-servo added a commit that referenced this pull request May 9, 2016
@bors-servo
Auto merge of #11092 - Ms2ger:text_content, r=jdm
d529d7e 
Move some code from ServoThreadSafeLayoutNode::text_content into script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11092)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

💔 Test failed - windows
@cbrewster
Copy link
Member

cbrewster commented May 9, 2016

@bors-servo retry

  • git
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

⌛ Testing commit a5be5a8 with merge 71eaba2...
bors-servo added a commit that referenced this pull request May 9, 2016
@bors-servo
Auto merge of #11092 - Ms2ger:text_content, r=jdm
Loading status checks…
71eaba2 
Move some code from ServoThreadSafeLayoutNode::text_content into script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11092)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit a5be5a8 into servo:master May 9, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:text_content branch May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @jdm @bors-servo @cbrewster @KiChjang
You can’t perform that action at this time.