gfx: Map CSS `normal` font weight to Regular font weight on the Mac. #11103

pcwalton · 2016-05-09T23:52:15Z

This series of commits fixes #9487, and improves the look of nytimes.com among others.

r? @metajack

This change is

highfive · 2016-05-09T23:52:19Z

Warning

These commits modify gfx code, but no tests are modified. Please consider adding a test!

pcwalton · 2016-05-09T23:53:06Z

cc @paulrouget

highfive · 2016-05-10T00:03:59Z

New code was committed to pull request.

metajack · 2016-05-10T02:43:37Z

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

metajack · 2016-05-10T02:44:52Z

@bors-servo r+

bors-servo · 2016-05-10T02:44:53Z

📌 Commit 8d74e7d has been approved by metajack

bors-servo · 2016-05-10T02:44:56Z

⌛ Testing commit 8d74e7d with merge e77e34c...


        Auto merge of #11103 - pcwalton:mac-font-matching, r=metajack

@metajack

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. This series of commits fixes #9487, and improves the look of nytimes.com among others. r? @metajack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)

bors-servo · 2016-05-10T03:25:43Z

💔 Test failed - mac-rel-css

highfive · 2016-05-10T03:25:46Z

  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-break-all-007.htm

  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-normal-hi-000.htm

highfive · 2016-05-10T04:57:52Z

New code was committed to pull request.

pcwalton · 2016-05-10T04:57:59Z

@bors-servo: r=metajack

Just updated test expectations.

bors-servo · 2016-05-10T04:58:00Z

📌 Commit 3d35e2a has been approved by metajack

bors-servo · 2016-05-10T05:29:49Z

⌛ Testing commit 3d35e2a with merge 9498a11...


        Auto merge of #11103 - pcwalton:mac-font-matching, r=metajack

@metajack

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. This series of commits fixes #9487, and improves the look of nytimes.com among others. r? @metajack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)

bors-servo · 2016-05-10T06:17:05Z

💔 Test failed - linux-rel

highfive · 2016-05-10T06:17:07Z

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-normal-hi-000.htm
  └   → /css-text-3_dev/html/word-break-normal-hi-000.htm 7a83d931c4369a4ca3febd013f724b7a26fc618f
/css-text-3_dev/html/reference/word-break-normal-hi-ref-000.htm b9ee751c30ac3d59328fc32a5aca1d5b9895f8ab
Testing 7a83d931c4369a4ca3febd013f724b7a26fc618f == b9ee751c30ac3d59328fc32a5aca1d5b9895f8ab

highfive · 2016-05-10T17:32:55Z

New code was committed to pull request.

pcwalton · 2016-05-10T17:34:26Z

@bors-servo: r=metajack

The failing test is Indic, so the results are meaningless.

bors-servo · 2016-05-10T17:34:27Z

📌 Commit 6d0e4de has been approved by metajack


        gfx: Perform fuzzy matching on font weights if an exact match wasn't

found. Partially addresses #190. Partially addresses #9487.


        gfx: Change the mapping from Mac weights to CSS weights so that 0.0 maps

to 400, not 500. CSS `normal` font-weight is specified as 400, while Mac "Regular" font weight is reported as 0.0. On the Mac, we need to center the two ranges on the same value to avoid choosing "Light" fonts where "Regular" would have been more appropriate. Closes #9487. fix for mac


        gfx: Implement `Debug` for `FontTemplate` instances.


        tests: Update test expectations.

bors-servo · 2016-05-10T19:44:39Z

⌛ Testing commit 6d0e4de with merge 5ffc58a...


        Auto merge of #11103 - pcwalton:mac-font-matching, r=metajack

@metajack

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. This series of commits fixes #9487, and improves the look of nytimes.com among others. r? @metajack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)

bors-servo · 2016-05-10T19:54:25Z

💔 Test failed - windows

pcwalton · 2016-05-10T20:16:48Z

@bors-servo: retry

infra

bors-servo · 2016-05-10T21:11:36Z

⌛ Testing commit 6d0e4de with merge 1fd9c55...


        Auto merge of #11103 - pcwalton:mac-font-matching, r=metajack

@metajack

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. This series of commits fixes #9487, and improves the look of nytimes.com among others. r? @metajack  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)

bors-servo · 2016-05-10T22:00:46Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned metajack May 9, 2016

highfive added the S-awaiting-review label May 9, 2016

pcwalton force-pushed the pcwalton:mac-font-matching branch from 7137626 to 8d74e7d May 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 10, 2016

highfive removed the S-tests-failed label May 10, 2016

highfive added the S-awaiting-review label May 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 10, 2016

highfive removed the S-awaiting-merge label May 10, 2016

highfive added the S-tests-failed label May 10, 2016

pcwalton force-pushed the pcwalton:mac-font-matching branch from 3d35e2a to 6d0e4de May 10, 2016

highfive added S-awaiting-review and removed S-tests-failed labels May 10, 2016

highfive removed the S-awaiting-review label May 10, 2016

gfx: Perform fuzzy matching on font weights if an exact match wasn't

479c6c9

found. Partially addresses #190. Partially addresses #9487.

highfive added the S-awaiting-merge label May 10, 2016

pcwalton added 3 commits May 9, 2016

gfx: Implement `Debug` for `FontTemplate` instances.

376c6b3

tests: Update test expectations.

Loading status checks…

6d0e4de

highfive added S-tests-failed and removed S-awaiting-merge labels May 10, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 10, 2016

bors-servo merged commit 6d0e4de into servo:master May 10, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 10, 2016

cbrewster mentioned this pull request Jul 2, 2016

Fonts not rendered with subpixel antialiasing #10199

Closed

servo / servo

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. #11103

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. #11103

pcwalton commented May 9, 2016 •

edited by larsbergstrom

highfive commented May 9, 2016

pcwalton commented May 9, 2016

highfive commented May 10, 2016

metajack commented May 10, 2016

metajack commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

highfive commented May 10, 2016

highfive commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

highfive commented May 10, 2016

highfive commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

servo / servo

Join GitHub today

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. #11103

gfx: Map CSS `normal` font weight to Regular font weight on the Mac. #11103

Conversation

pcwalton commented May 9, 2016 • edited by larsbergstrom

highfive commented May 9, 2016

pcwalton commented May 9, 2016

highfive commented May 10, 2016

metajack commented May 10, 2016

metajack commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

highfive commented May 10, 2016

highfive commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

highfive commented May 10, 2016

highfive commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

pcwalton commented May 10, 2016

bors-servo commented May 10, 2016

bors-servo commented May 10, 2016

pcwalton commented May 9, 2016 •

edited by larsbergstrom