Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `text-align: justify` incremental layout safe #11109

Merged
merged 1 commit into from May 10, 2016
Merged

Make `text-align: justify` incremental layout safe #11109

merged 1 commit into from May 10, 2016

Conversation

@kaksmet
Copy link
Contributor

kaksmet commented May 10, 2016 •
edited by larsbergstrom

Closes #10499
Closes #9057

This change is Reviewable
@kaksmet
Make `text-align: justify` incremental layout safe
Loading status checks…
0f983cd
@mbrubeck
Copy link
Contributor

mbrubeck commented May 10, 2016

@bors-servo r+

Looks great, thanks!

By the way, while playing with the test case, I noticed that justified lines are sometimes a little too long or too short (by about one space width). I suspect there's an unrelated bug maybe caused by rounding errors or by trimmed whitespace. Let me know if you want to investigate that too...

Previously, kaksmet wrote…

Make text-align: justify incremental layout safe

Closes #10499

Closes #9057

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2016

📌 Commit 0f983cd has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2016

⌛ Testing commit 0f983cd with merge 069be91...
bors-servo added a commit that referenced this pull request May 10, 2016
@bors-servo
Auto merge of #11109 - kaksmet:justify-fix, r=mbrubeck
Loading status checks…
069be91 
Make `text-align: justify` incremental layout safe

Closes #10499
Closes #9057

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11109)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 0f983cd into servo:master May 10, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kaksmet kaksmet deleted the kaksmet:justify-fix branch May 10, 2016
@bors-servo bors-servo mentioned this pull request May 10, 2016
Closed
@mbrubeck mbrubeck mentioned this pull request May 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kaksmet @mbrubeck @bors-servo @highfive
You can’t perform that action at this time.