Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netsurfcss and other follow up on the new style system #1112

Merged
merged 3 commits into from Oct 23, 2013
Merged

Remove netsurfcss and other follow up on the new style system #1112

merged 3 commits into from Oct 23, 2013

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 23, 2013

Following up on #1109. These three commits are independent.
SimonSapin added 3 commits Oct 23, 2013
@SimonSapin
Attempt to fix incremental layout
86da932 
I have no idea how to test it,
but this code builds and is close enough to what it was befor #1109.

Review much needed.
@SimonSapin
Remove (now unused) NetSurf’s libcss and libwapcaplet.
2045f6a 
This removes four submodules (two C libraries and their Rust bindings.)
@SimonSapin
Remove the 'border-width: 0' hack.
Loading status checks…
ab0d620 
This was to work-around a netsurfcss quirk.
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on ab0d620 Oct 23, 2013

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on ab0d620 Oct 23, 2013

saw approval from metajack
at SimonSapin@ab0d620

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 23, 2013

merging SimonSapin/servo/newnewcss = ab0d620 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 23, 2013

SimonSapin/servo/newnewcss = ab0d620 merged ok, testing candidate = 1ed87f9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 23, 2013

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/495
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/450

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 23, 2013

fast-forwarding master to auto = 1ed87f9
bors-servo pushed a commit that referenced this pull request Oct 23, 2013
bors-servo
auto merge of #1112 : SimonSapin/servo/newnewcss, r=metajack
1ed87f9 
Following up on #1109. These three commits are independent.
@bors-servo bors-servo merged commit ab0d620 into servo:master Oct 23, 2013
1 check passed
1 check passed
default all tests passed
@SimonSapin SimonSapin mentioned this pull request Oct 23, 2013
Merged
@SimonSapin SimonSapin mentioned this pull request Nov 5, 2013
Closed
This was referenced Dec 9, 2013
Closed
Closed
Closed
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
@cynthia
Merge pull request servo#1112 from scottgonzalez/pointerup
77c254f 
Test Assertions 3.1, 3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @bors-servo @metajack
You can’t perform that action at this time.