Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable codegen-units due to performance regressions #11123
Merged
Conversation
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 11, 2016
Disable codegen-units due to performance regressions r? @pcwalton Fixes #11102. CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11123) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
May 12, 2016
Disable codegen-units due to performance regressions r? @pcwalton Fixes #11102. CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11123) <!-- Reviewable:end -->
|
Very interesting data point @larsbergstrom! In the standard library we've had the rule of thumb so far that |
|
|
bors-servo
added a commit
that referenced
this pull request
May 12, 2016
…rubeck Remove codegen-units from cef r? @mbrubeck @metajack Should fix regression in #11123 that caused build-cef to rebuild again. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11156) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedMay 11, 2016
•
edited
r? @pcwalton
Fixes #11102.
CC @alexcrichton, @nmatsakis - basically,
codegen-unitsis nice for local compilation speedups but results in too many perf regressions to keep it for release builds.This change is