Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glutin: On desktop, use the same app icon we use on Android. #11126

Closed
wants to merge 1 commit into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented May 11, 2016

This makes the app easier to pick out in Instruments.app and so forth.

Requires servo/glutin#86, which itself requires servo/cocoa-rs#124.

r? @metajack


This change is Reviewable

This makes the app easier to pick out in Instruments.app and so forth.

Requires servo/glutin#86, which itself requires servo/cocoa-rs#124.
@metajack
Copy link
Contributor

metajack commented May 11, 2016

r=me when the other things land.

Previously, pcwalton (Patrick Walton) wrote…

glutin: On desktop, use the same app icon we use on Android.

This makes the app easier to pick out in Instruments.app and so forth.

Requires servo/glutin#86, which itself requires servo/cocoa-rs#124.

r? @metajack


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nox
Copy link
Member

nox commented May 16, 2016

Superseded by #11199.

@nox nox closed this May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.