When webdriver is getting a pipeline id, it should wait for the pipeline document to be ready

[asajeffrey]

Thank you for contributing to Servo! Please add an X inside each [ ] when the step is complete, and replace __ with appropriate data:

• ./mach build does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #11117 (github issue number if applicable).

Either:

• There are tests for these changes OR
• These changes do not require tests because they only impact webdriver

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @jgraham: components/webdriver_server/lib.rs

[asajeffrey]

r? @jgraham

[jgraham]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/compositing/constellation.rs, line 1397 [r1] (raw file):

            .and_then(|frame_id| self.frames.get(&frame_id))
            .map(|frame| frame.current);
        let current_pipeline_id_loaded = current_pipeline_id

I think you should just merge this into the previous line like .map(|frame| (frame.current, true))

---

Comments from Reviewable

[asajeffrey]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/compositing/constellation.rs, line 1397 [r1] (raw file):

Previously, jgraham wrote…

I think you should just merge this into the previous line like .map(|frame| (frame.current, true))

We use current_pipeline_id later on in .find(|x| x.old_pipeline_id == current_pipeline_id).

---

Comments from Reviewable

[jgraham]

Review status: all files reviewed at latest revision, all discussions resolved.

---

components/compositing/constellation.rs, line 1397 [r1] (raw file):

Previously, asajeffrey (Alan Jeffrey) wrote…

We use current_pipeline_id later on in .find(|x| x.old_pipeline_id == current_pipeline_id).

Well I can't read. I guess that doesn't preclude it, but sure, this is fine.

---

Comments from Reviewable

[jgraham]

@bors-servo: r+

[bors-servo]

📌 Commit 00a8efe has been approved by jgraham

[bors-servo]

⌛ Testing commit 00a8efe with merge b3c15fd...

[bors-servo]

💔 Test failed - linux-rel

[highfive]

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/border-bottom-color-028.htm
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread 'Constellation' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Error { repr: Os { code: 104, message: "Connection reset by peer" } })', ../src/libcore/result.rs:785
  │ stack backtrace:
  │    1:     0x7f856eae66a0 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:     0x7f856eaede1b - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:     0x7f856eaeda83 - std::panicking::default_hook::hc2c969e7453d080c
  │    4:     0x7f856e24c287 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h625edf9a36237d31
  │    5:     0x7f856ead3b63 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:     0x7f856ead55a8 - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:     0x7f856eae58f1 - rust_begin_unwind
  │    8:     0x7f856eb24e9f - core::panicking::panic_fmt::h257ceb0aa351d801
  │    9:     0x7f856dd05cce - core::result::unwrap_failed::h330560dbaf0a51e7
  │   10:     0x7f856dd2bfce - gfx::font_cache_thread::FontCacheThread::exit::ha2f1f4fd6ebc6397
  │   11:     0x7f856d0ebd28 - _<compositing..Constellation<LTF, STF>>::handle_exit::hae6d0417398a20fa
  │   12:     0x7f856d0c15c2 - _<compositing..Constellation<LTF, STF>>::handle_request::h3c97e2d5b7782802
  │   13:     0x7f856d0b520c - std::sys_common::unwind::t</span><span class="stdout">ry::try_fn::h12e8cdd1c52fbc04
  │   14:     0x7f856eae587b - __rust_try
  │   15:     0x7f856eae580d - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   16:     0x7f856d0b67fa - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h4fbd446f73dda14f
  │   17:     0x7f856eaec2d4 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   18:     0x7f856aacc181 - start_thread
  │   19:     0x7f856a5e347c - __clone
  └   20:                0x0 - &lt;unknown&gt;

[jgraham]

@bors-servo retry

[bors-servo]

⌛ Testing commit 00a8efe with merge 1a834b5...

[Ms2ger]

That was #8815

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows