Reworded some of PULL_REQUEST_TEMPLATE.md #11141

asajeffrey · 2016-05-11T20:43:15Z

Thank you for contributing to Servo! Please add an X inside each [ ] when the step is complete, and replace __ with appropriate data:

./mach build does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

Either:

There are tests for these changes OR
These changes do not require tests because they are just the PR template

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

r? @jdm

This change is


        Reworded some of PULL_REQUEST_TEMPLATE.md

jdm · 2016-05-11T20:51:11Z

@bors-servo: r+

bors-servo · 2016-05-11T20:51:13Z

📌 Commit 11fc1dd has been approved by jdm

bors-servo · 2016-05-12T09:16:10Z

⌛ Testing commit 11fc1dd with merge d67ab23...


        Auto merge of #11141 - asajeffrey:reword-pr-template, r=jdm

@jdm

Reworded some of PULL_REQUEST_TEMPLATE.md Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [X] These changes do not require tests because they are just the PR template Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. r? @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11141)

bors-servo · 2016-05-12T09:56:20Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-12T09:56:23Z

  ▶ TIMEOUT [expected OK] /html/dom/reflection-embedded.html
  │ 
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ stack backtrace:
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107bff129 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x107be63bc - std::rand::thread_rng::h789d00d1fce4f79b
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    9:        0x10656072c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10659e61b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107bff129 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x107be63bc - std::rand::thread_rng::h789d00d1fce4f79b
  │    9:        0x10656072c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10659e61b - net::http_loader::load::h68b5ac4fbf09d0a1
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107bff129 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x107be63bc - std::rand::thread_rng::h789d00d1fce4f79b
  │    9:        0x10656072c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10659e61b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x1</span><span class="stdout">0659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107bff129 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x107be63bc - std::rand::thread_rng::h789d00d1fce4f79b
  │    9:        0x10656072c - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10659e61b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x107bf86e8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x107bfeb05 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x107bfe71e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x1073c50f2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x107be5db8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x107be76ee - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x107a0276f - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x107a025ac - rand::thread_rng::h685796b33c6d5157
  │    9:        0x1073efa22 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10659f2eb - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10659ade0 - std::sys_common::unwind::try::try_fn::haa463cfb1553106f
  │   12:        0x107bf794b - __rust_try
  │   13:        0x107bf78d3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10659cae1 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hcf395b9e94fe155c
  │   15:        0x107bfdb88 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  └   17:     0x7fff8c3c1fd6 - _pthread_start

emilio · 2016-05-12T11:25:14Z

@bors-servo: retry

#11100

(Shouldn't we have rollups for this kind of thing?)

bors-servo · 2016-05-12T11:37:40Z

⌛ Testing commit 11fc1dd with merge ef3c410...


        Auto merge of #11141 - asajeffrey:reword-pr-template, r=jdm

@jdm

Reworded some of PULL_REQUEST_TEMPLATE.md Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [X] These changes do not require tests because they are just the PR template Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. r? @jdm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11141)

bors-servo · 2016-05-12T12:28:11Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

Reworded some of PULL_REQUEST_TEMPLATE.md

Loading status checks…

11fc1dd

highfive assigned jdm May 11, 2016

highfive added the S-awaiting-review label May 11, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 11, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 12, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels May 12, 2016

bors-servo merged commit 11fc1dd into servo:master May 12, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 12, 2016

servo / servo

Reworded some of PULL_REQUEST_TEMPLATE.md #11141

Reworded some of PULL_REQUEST_TEMPLATE.md #11141

asajeffrey commented May 11, 2016 •

edited by larsbergstrom

jdm commented May 11, 2016

bors-servo commented May 11, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

servo / servo

Join GitHub today

Reworded some of PULL_REQUEST_TEMPLATE.md #11141

Reworded some of PULL_REQUEST_TEMPLATE.md #11141

Conversation

asajeffrey commented May 11, 2016 • edited by larsbergstrom

jdm commented May 11, 2016

bors-servo commented May 11, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

bors-servo commented May 12, 2016

bors-servo commented May 12, 2016

asajeffrey commented May 11, 2016 •

edited by larsbergstrom