codegen: Fix dictionary handling and semantics #11155

emilio · 2016-05-12T13:43:47Z

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #11152 (github issue number if applicable).

Either:

There are tests for these changes OR
These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

Fixes #11152

This change is


        codegen: Use the non-mangled name in set_dictionary_property

Fixes #11152

highfive · 2016-05-12T13:43:51Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/bindings/codegen/CodegenRust.py

highfive · 2016-05-12T13:43:52Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

emilio · 2016-05-12T13:44:38Z

r? @asajeffrey

Not sure about how to test it, since we only trigger mozbrowser errors on panics... I'll look for some other reserved keyword in the idls.

asajeffrey · 2016-05-12T13:58:37Z

Indeed, testing is going to be tricky.

asajeffrey · 2016-05-12T14:00:47Z

r=me once the testing story is worked out.

highfive · 2016-05-12T16:12:43Z

New code was committed to pull request.

emilio · 2016-05-12T16:18:56Z

I'm having local problems with the test I've just written, so I'm going to do a try run.

The problem is that for some reason even when the isKeywordTypeSuccess function in the bindings output is called, the rust function IsKeywordTypeSuccess isn't, and the script thread goes into an idle state before finishing to execute the script.

So the only output I'm seeing is:

created
received: 
success

~~I'm fearing this is a bug in our conversions for TestDictionary that somehow corrupts the stack, but I'm not sure. Running this with debug-mozjs gives no clues, and the same result.~~ (See jdm's comment below)

emilio · 2016-05-12T16:19:05Z

@bors-servo: try

bors-servo · 2016-05-12T16:19:09Z

⌛ Trying commit a7748c8 with merge fbb6b30...


        Auto merge of #11155 - emilio:codegen-dict-keyword, r=<try>

codegen: Use the non-mangled name in set_dictionary_property Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11152 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. Fixes #11152  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11155)

highfive · 2016-05-12T16:19:57Z

New code was committed to pull request.

emilio · 2016-05-12T16:20:17Z

@bors-servo: try- clean try

(Fixed tidy)

jdm · 2016-05-12T16:26:37Z

Rather than corrupting the stack, I suspect that a generated binding function is returning false at some point which silently suspends JS execution.

highfive · 2016-05-12T18:34:31Z

New code was committed to pull request.

highfive · 2016-05-12T18:37:54Z

New code was committed to pull request.


        bindings: Add test for keywords in dictionaries

highfive · 2016-05-12T18:39:42Z

New code was committed to pull request.

highfive · 2016-05-12T18:50:12Z

New code was committed to pull request.

highfive · 2016-05-12T19:09:10Z

New code was committed to pull request.

emilio · 2016-05-12T19:09:31Z

This should be ready for re-review.

The problem was that when we convert a rust dictionary to js, we setted the properties even when they were None (that is the value we use to represent that a prop isn't setted in JS). It seems this was not the correct behaviour per http://heycam.github.io/webidl/#es-dictionary, and the PR changes it.

Going to do a try run to check if we rely on the old semantics:

@bors-servo: try

bors-servo · 2016-05-13T08:57:30Z

⌛ Testing commit 85cc140 with merge 669420e...


        Auto merge of #11155 - emilio:codegen-dict-keyword, r=Ms2ger

codegen: Fix dictionary handling and semantics Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11152 (github issue number if applicable). Either: - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. Fixes #11152  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11155)

bors-servo · 2016-05-13T09:30:36Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-13T09:30:39Z

  ▶ TIMEOUT [expected OK] /cors/redirect-origin.htm
  │ 
  │ thread &#39;http_loader for http://www1.web-platform.test:8000/cors/resources/cors-makeheader.py?origin=http://www1.web-platform.test:8000&amp;location=http%3A%2F%2Fwww1.web-platform.test%3A8000%2Fcors%2Fresources%2Fcors-makeheader.py%3Forigin%3D*%26get_value%3Dlast%2642_1&amp;42_0&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │ stack backtrace:
  │    1:        0x10ada3e08 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10adaa225 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10ada9e3e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10a514d92 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10ad914d8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10ad92e0e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10ace7abf - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │ thread &#39;http_loader for http://www1.web-platform.test:8000/cors/resources/cors-makeheader.py?origin=http://web-platform.test:8000&amp;location=http%3A%2F%2Fwww2.web-platform.test%3A8000%2Fcors%2Fresources%2Fcors-makeheader.py%3Forigin%3Dhttp%3A%2F%2Fweb-platform.test%3A8000%26get_value%3Dlast%2635_1&amp;35_0&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    8:        0x10ace78fc - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10acb0f92 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10989c22b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x109897d30 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10ada306b - __rust_try
  │   13:        0x10ada2ff3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x109899a31 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10ada92a8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  │   17:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10ada3e08 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10adaa225 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10ada9e3e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10a514d92 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10ad914d8 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10ad92e0e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10ace7abf - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10ace78fc - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10acb0f92 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10989c22b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x109897d30 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10ada306b - __rust_try
  │   13:        0x10ada2ff3 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x109899a31 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
</span><span class="stdout">  │   15:        0x10ada92a8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff8c3c2059 - _pthread_body
  └   17:     0x7fff8c3c1fd6 - _pthread_start

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  │ TIMEOUT [expected PASS] remote (http://web-platform.test:8000) to remote2 (http://web-platform.test:8000), expect to fail
  └   → Test timed out

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  └ PASS [expected FAIL] remote (none) to remote2 (*), expect to fail

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  │ TIMEOUT [expected FAIL] remote (http://www1.web-platform.test:8000) to remote (*), expect to fail
  └   → Test timed out

  ▶ OK [expected TIMEOUT] /domparsing/DOMParser-parseFromString-xml.html

  ▶ Unexpected subtest result in /domparsing/DOMParser-parseFromString-xml.html:
  │ FAIL [expected PASS] Should return an error document for XML wellformedness errors in type application/xml
  │   → &#39;application/xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] Should return an error document for XML wellformedness errors in type application/xhtml+xml
  │   → &#39;application/xhtml+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] Should return an error document for XML wellformedness errors in type image/svg+xml
  │   → &#39;image/svg+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ 
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:33:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:31:3
  └ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:14:1

  ▶ Unexpected subtest result in /domparsing/DOMParser-parseFromString-xml.html:
  │ FAIL [expected PASS] XMLDocument interface for incorrectly parsed document with type application/xml
  │   → &#39;application/xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] XMLDocument interface for incorrectly parsed document with type application/xhtml+xml
  │   → &#39;application/xhtml+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] XMLDocument interface for incorrectly parsed document with type image/svg+xml
  │   → &#39;image/svg+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ 
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:42:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:40:3
  └ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:14:1

  ▶ Unexpected subtest result in /domparsing/DOMParser-parseFromString-xml.html:
  │ FAIL [expected PASS] XMLDocument interface for correctly parsed document with type application/xml
  │   → &#39;application/xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] XMLDocument interface for correctly parsed document with type application/xhtml+xml
  │   → &#39;application/xhtml+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] XMLDocument interface for correctly parsed document with type image/svg+xml
  │   → &#39;image/svg+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ 
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:27:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:25:3
  └ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:14:1

  ▶ Unexpected subtest result in /domparsing/DOMParser-parseFromString-xml.html:
  │ FAIL [expected TIMEOUT] Should parse correctly in type application/xml
  │   → &#39;application/xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] Should parse correctly in type application/xhtml+xml
  │   → &#39;application/xhtml+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ FAIL [expected PASS] Should parse correctly in type image/svg+xml
  │   → &#39;image/svg+xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ 
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:17:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:15:3
  └ @http://web-platform.test:8000/domparsing/DOMParser-parseFromString-xml.html:14:1

  ▶ OK [expected TIMEOUT] /html/browsers/the-window-object/Document-defaultView.html

  ▶ Unexpected subtest result in /html/browsers/the-window-object/Document-defaultView.html:
  │ FAIL [expected TIMEOUT] Document created with XML DOMParser
  │   → &#39;application/xml&#39; is not a valid enum value for enumeration &#39;SupportedType&#39;.
  │ 
  │ @http://web-platform.test:8000/html/browsers/the-window-object/Document-defaultView.html:22:11
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/html/browsers/the-window-object/Document-defaultView.html:20:1

  ▶ Unexpected subtest result in /html/browsers/the-window-object/Document-defaultView.html:
  │ FAIL [expected PASS] Document created with HTML DOMParser
  │   → assert_equals: expected null but got object &#34;[object Window]&#34;
  │ 
  │ @http://web-platform.test:8000/html/browsers/the-window-object/Document-defaultView.html:29:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/html/browsers/the-window-object/Document-defaultView.html:26:1


        codegen: Throw on an invalid enum value when appropiate


        codegen: Throw a more descriptive invalid enum message

highfive · 2016-05-13T09:44:48Z

New code was committed to pull request.

emilio · 2016-05-13T09:47:06Z

Updated test expectations, the cors test seems to be intermittent, the other failures are old expected timeouts uncovered by this patch.

@bors-servo: r=Ms2ger

bors-servo · 2016-05-13T09:47:07Z

📌 Commit 91101f6 has been approved by Ms2ger

bors-servo · 2016-05-13T09:47:10Z

⌛ Testing commit 91101f6 with merge 221db56...


        Auto merge of #11155 - emilio:codegen-dict-keyword, r=Ms2ger

codegen: Fix dictionary handling and semantics Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11152 (github issue number if applicable). Either: - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. Fixes #11152  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11155)

bors-servo · 2016-05-13T10:27:11Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-13T10:27:14Z

  ▶ TIMEOUT [expected OK] /html/dom/reflection-embedded.html
  │ 
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ stack backtrace:
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b63f889 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    8:        0x10b626b1c - std::rand::thread_rng::h789d00d1fce4f79b
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    9:        0x10a0f26bc - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10a1305a5 - net::http_loader::load::h68b5ac4fbf09d0a1
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │ thread &#39;http_loader for http://web-platform.test:8000/html/dom/test-valueOf&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs:873
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b63f889 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x10b626b1c - std::rand::thread_rng::h789d00d1fce4f79b
  │    9:        0x10a0f26bc - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10a1305a5 - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b63f889 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    8:        0x10b626b1c - std::rand::thread_rng::h789d00d1fce4f79b
  │    9:        0x10a0f26bc - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   10:        0x10a1305a5 - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b57caff - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10b57c93c - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10b545fd2 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10a13126b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b57caff - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10b57c93c - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10b545fd2 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10a13126b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x1</span><span class="stdout">0b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b57caff - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10b57c93c - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10b545fd2 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10a13126b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b57caff - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10b57c93c - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10b545fd2 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10a13126b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  │   17:     0x7fff95827fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x10b638e48 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10b63f265 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10b63ee7e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10ada9dd2 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h0bad41b0b38a855d
  │    5:        0x10b626518 - std::sys_common::unwind::begin_unwind_inner::h30e12d15ce2b2e25
  │    6:        0x10b627e4e - std::sys_common::unwind::begin_unwind_fmt::hb2de8a9968d38523
  │    7:        0x10b57caff - rand::thread_rng::THREAD_RNG_KEY::__init::h95086aa3feb19f11
  │    8:        0x10b57c93c - rand::thread_rng::h685796b33c6d5157
  │    9:        0x10b545fd2 - uuid::Uuid::new_v4::hf5742953332a48bd
  │   10:        0x10a13126b - net::http_loader::load::h68b5ac4fbf09d0a1
  │   11:        0x10a12cd70 - std::sys_common::unwind::try::try_fn::hf6af0c92daa7bda1
  │   12:        0x10b6380ab - __rust_try
  │   13:        0x10b638033 - std::sys_common::unwind::inner_try::h47a4d9cd4a369dcd
  │   14:        0x10a12ea71 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h3f7304fdb410ded0
  │   15:        0x10b63e2e8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   16:     0x7fff95828059 - _pthread_body
  └   17:     0x7fff95827fd6 - _pthread_start

emilio · 2016-05-13T10:53:35Z

@bors-servo: retry

#11100

bors-servo · 2016-05-13T10:53:37Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-05-13T11:31:53Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

codegen: Use the non-mangled name in set_dictionary_property

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

203898c

Fixes #11152

highfive assigned glennw May 12, 2016

highfive added the S-awaiting-review label May 12, 2016

highfive assigned asajeffrey and unassigned glennw May 12, 2016

emilio force-pushed the emilio:codegen-dict-keyword branch from a7748c8 to 76740e3 May 12, 2016

emilio force-pushed the emilio:codegen-dict-keyword branch from 76740e3 to 35e7843 May 12, 2016

emilio force-pushed the emilio:codegen-dict-keyword branch from 35e7843 to 0edf400 May 12, 2016

bindings: Add test for keywords in dictionaries

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

f893a2e

emilio force-pushed the emilio:codegen-dict-keyword branch from 0edf400 to 016b3ad May 12, 2016

emilio force-pushed the emilio:codegen-dict-keyword branch from 016b3ad to 45e5781 May 12, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 13, 2016

emilio added 2 commits May 13, 2016

codegen: Throw on an invalid enum value when appropiate

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

e50d4b7

codegen: Throw a more descriptive invalid enum message

Unverified

This user has not uploaded their public key yet.

GPG key ID: 056B727BB9C1027C Learn about signing commits

Loading status checks…

91101f6

emilio force-pushed the emilio:codegen-dict-keyword branch from 85cc140 to 91101f6 May 13, 2016

highfive added S-awaiting-review and removed S-tests-failed labels May 13, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 13, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels May 13, 2016

bors-servo merged commit 91101f6 into servo:master May 13, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 13, 2016

This was referenced May 13, 2016

mozbrowsererror detail.type is undefined #11152

Closed

Catch pipeline crashes and report error browserhtml/browserhtml#1001

Closed

emilio deleted the emilio:codegen-dict-keyword branch May 14, 2016

servo / servo

codegen: Fix dictionary handling and semantics #11155

codegen: Fix dictionary handling and semantics #11155

emilio commented May 12, 2016 •

edited

highfive commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016 •

edited

asajeffrey commented May 12, 2016

asajeffrey commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016 •

edited

emilio commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

jdm commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

highfive commented May 13, 2016

highfive commented May 13, 2016

emilio commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

highfive commented May 13, 2016

emilio commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

servo / servo

Join GitHub today

codegen: Fix dictionary handling and semantics #11155

codegen: Fix dictionary handling and semantics #11155

Conversation

emilio commented May 12, 2016 • edited

highfive commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016 • edited

asajeffrey commented May 12, 2016

asajeffrey commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016 • edited

emilio commented May 12, 2016

bors-servo commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

jdm commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

highfive commented May 12, 2016

emilio commented May 12, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

highfive commented May 13, 2016

highfive commented May 13, 2016

emilio commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

highfive commented May 13, 2016

emilio commented May 13, 2016

bors-servo commented May 13, 2016

bors-servo commented May 13, 2016

emilio commented May 12, 2016 •

edited

emilio commented May 12, 2016 •

edited

emilio commented May 12, 2016 •

edited