Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Add expect messages to FontCacheThread::exit() #11166

Merged
merged 1 commit into from May 13, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

gfx: Add expect messages to FontCacheThread::exit()

One of these two unwraps is the one that is causing most occurrences
of #8815.

I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
  • Loading branch information
emilio committed May 12, 2016
commit f6434a9790edb130c9f2a0c8d67ee9cdd5d031c9
@@ -438,8 +438,8 @@ impl FontCacheThread {

pub fn exit(&self) {
let (response_chan, response_port) = ipc::channel().unwrap();
self.chan.send(Command::Exit(response_chan)).unwrap();
response_port.recv().unwrap();
self.chan.send(Command::Exit(response_chan)).expect("Couldn't send FontCacheThread exit message");
response_port.recv().expect("Couldn't receive FontCacheThread reply");
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.