Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneralise RootedVec::<JS<T>>::r as [JS<T>]::r #11171
Conversation
highfive
commented
May 13, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 13, 2016
|
This supersedes #11162. |
|
r? @Ms2ger |
highfive
commented
May 13, 2016
|
New code was committed to pull request. |
|
Fine by me, r? @jdm for the extra |
|
Fails tidy:
|
highfive
commented
May 13, 2016
|
New code was committed to pull request. |
|
|
highfive
commented
May 16, 2016
|
New code was committed to pull request. |
|
I'm not convinced that this is a strict improvement. Conceptually the implementation is nicer to read, but the extra import required for every file that needs to interact with a GlobalRoot is a papercut that outweighs that. |
|
|
|
So, what's the status on this one? Is it just a change we don't want to make at all? Or should it be rebased and fixed up in some way? @jdm? |
|
Previous discussions have not convinced me that this change is worth merging. |
nox commentedMay 13, 2016
•
edited
This change is