htmlanchorelement getter work before href setting is called #11182

mrmiywj · 2016-05-14T18:20:49Z

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #10876 (github issue number if applicable).

Either:

There are tests for these changes OR
These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

This change is

highfive · 2016-05-14T18:20:54Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/htmlanchorelement.rs

KiChjang · 2016-05-14T22:10:12Z

You'll need to use ./mach create-wpt tests/wpt/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_attribute-getter-setter-sample.html to create a new test, otherwise the test harness wouldn't run your test.

highfive · 2016-05-16T04:42:42Z

New code was committed to pull request.

mrmiywj · 2016-05-16T04:44:07Z

cc @KiChjang
It works now. Since there is another test file to test setters and getters. I just wrote a test on calling getters before setters called.

highfive · 2016-05-16T05:47:42Z

New code was committed to pull request.

KiChjang · 2016-05-16T10:10:22Z

...inks/links-created-by-a-and-area-elements/htmlanchorelement-getters-work-before-setters.html

+<a href="https://anonymous:pwd@developer.mozilla.org:1234/en-US/">a10</a>
+<script>
+function test_gettersetter(property, result, url) {
+  var a = document.querySelector('a[href="'+url+'"]');


document.getElementById("a1");

KiChjang · 2016-05-16T10:10:54Z

...inks/links-created-by-a-and-area-elements/htmlanchorelement-getters-work-before-setters.html

+<title>HTMLAnchorElement getters before setters called</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<a href="http://google.com?hi">a1</a>


You can change all of these two <a id=a1 href=.../>

highfive · 2016-05-16T10:18:51Z

New code was committed to pull request.

mrmiywj · 2016-05-16T10:19:01Z

cc @KiChjang

KiChjang · 2016-05-16T10:23:54Z

components/script/dom/htmlanchorelement.rs

@@ -91,6 +91,20 @@ impl VirtualMethods for HTMLAnchorElement {
        Some(self.upcast::<HTMLElement>() as &VirtualMethods)
    }

+    fn attribute_mutated(&self, attr: &Attr, mutation: AttributeMutation) {
+        self.super_type().unwrap().attribute_mutated(attr, mutation);
+        match attr.local_name() {


if attr.local_name() == &atom!("href") { if self.url.is_mutably_borrowed() { return; } self.set_url(); }

highfive · 2016-05-16T10:31:11Z

New code was committed to pull request.

mrmiywj · 2016-05-16T10:31:18Z

cc @KiChjang
Thx!

KiChjang · 2016-05-16T10:35:11Z

It doesn't look like the latest commit changed anything.

highfive · 2016-05-16T10:38:34Z

New code was committed to pull request.

highfive · 2016-05-17T16:13:45Z

New code was committed to pull request.

KiChjang · 2016-05-17T16:14:17Z

@bors-servo r+

bors-servo · 2016-05-17T16:14:18Z

📌 Commit d4f125e has been approved by KiChjang

bors-servo · 2016-05-17T18:01:45Z

⌛ Testing commit d4f125e with merge 4635034...


        Auto merge of #11182 - mrmiywj:add-attribute-mutated, r=KiChjang

htmlanchorelement getter work before href setting is called Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10876 (github issue number if applicable). Either: - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11182)

bors-servo · 2016-05-17T19:02:55Z

💔 Test failed - mac-rel-wpt

highfive · 2016-05-17T19:02:59Z

  ▶ Unexpected subtest result in /url/a-element-xhtml.xhtml:
  │ FAIL [expected PASS] Parsing: &lt;http:/:@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:a:b@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/a:b@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http::@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:@:www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/@:www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;../i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;../i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;/i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;/i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;?i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;?i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ 
  │ runURLTests/&lt;@http://web-platform.test:8000/url/a-element.js:33:11
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ runURLTests@http://web-platform.test:8000/url/a-element.js:29:5
  │ request.onload&lt;@http://web-platform.test:8000/url/a-element.js:7:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  └ Test.prototype.step_func/&lt;@http://web-platform.test:8000/resources/testharness.js:1421:20

  ▶ Unexpected subtest result in /url/a-element.html:
  │ FAIL [expected PASS] Parsing: &lt;http:/:@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:a:b@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/a:b@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http::@/www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:@:www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;http:/@:www.example.com&gt; against &lt;about:blank&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;../i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;../i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;/i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;/i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;?i&gt; against &lt;sc:sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ FAIL [expected PASS] Parsing: &lt;?i&gt; against &lt;sc:sd/sd&gt;
  │   → assert_unreached: Expected URL to fail parsing Reached unreachable code
  │ 
  │ runURLTests/&lt;@http://web-platform.test:8000/url/a-element.js:33:11
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ runURLTests@http://web-platform.test:8000/url/a-element.js:29:5
  │ request.onload&lt;@http://web-platform.test:8000/url/a-element.js:7:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  └ Test.prototype.step_func/&lt;@http://web-platform.test:8000/resources/testharness.js:1421:20


        htmlanchorelement getter work before href setting is called

update tests rewrite it

highfive · 2016-05-18T04:38:56Z

New code was committed to pull request.

KiChjang · 2016-05-18T05:05:54Z

@bors-servo r+

bors-servo · 2016-05-18T05:05:56Z

📌 Commit 904e9ea has been approved by KiChjang

bors-servo · 2016-05-18T05:05:59Z

⌛ Testing commit 904e9ea with merge aa8c835...


        Auto merge of #11182 - mrmiywj:add-attribute-mutated, r=KiChjang

htmlanchorelement getter work before href setting is called Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10876 (github issue number if applicable). Either: - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11182)

bors-servo · 2016-05-18T05:50:05Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

paulrouget · 2016-05-19T04:41:06Z

This causes a crash: #11261

highfive assigned nox May 14, 2016

highfive added the S-awaiting-review label May 14, 2016

KiChjang added S-needs-code-changes and removed S-awaiting-review labels May 14, 2016

KiChjang assigned KiChjang and unassigned nox May 14, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels May 16, 2016

KiChjang reviewed May 16, 2016
View changes

KiChjang added S-needs-code-changes and removed S-awaiting-review labels May 16, 2016

highfive removed the S-needs-code-changes label May 16, 2016

highfive added the S-awaiting-review label May 16, 2016

KiChjang reviewed May 16, 2016
View changes

KiChjang added S-needs-code-changes and removed S-awaiting-review labels May 16, 2016

highfive removed the S-needs-code-changes label May 16, 2016

highfive added the S-awaiting-review label May 16, 2016

KiChjang added S-needs-code-changes and removed S-awaiting-review labels May 17, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels May 17, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 17, 2016

highfive removed the S-awaiting-merge label May 17, 2016

highfive added the S-tests-failed label May 17, 2016

htmlanchorelement getter work before href setting is called

Loading status checks…

904e9ea

update tests rewrite it

highfive added S-awaiting-review and removed S-tests-failed labels May 18, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 18, 2016

bors-servo merged commit 904e9ea into servo:master May 18, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 18, 2016

jdm mentioned this pull request May 19, 2016

Servo crash in script::dom::htmlanchorelement::HTMLAnchorElement::update_href #11261

Closed

servo / servo

htmlanchorelement getter work before href setting is called #11182

htmlanchorelement getter work before href setting is called #11182

mrmiywj commented May 14, 2016 •

edited

highfive commented May 14, 2016

KiChjang commented May 14, 2016

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

highfive commented May 16, 2016

This comment has been minimized.

This comment has been minimized.

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

This comment has been minimized.

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

KiChjang commented May 16, 2016

highfive commented May 16, 2016

highfive commented May 17, 2016

KiChjang commented May 17, 2016

bors-servo commented May 17, 2016

bors-servo commented May 17, 2016

bors-servo commented May 17, 2016

highfive commented May 17, 2016

highfive commented May 18, 2016

KiChjang commented May 18, 2016

bors-servo commented May 18, 2016

bors-servo commented May 18, 2016

bors-servo commented May 18, 2016

paulrouget commented May 19, 2016

servo / servo

Join GitHub today

htmlanchorelement getter work before href setting is called #11182

htmlanchorelement getter work before href setting is called #11182

Conversation

mrmiywj commented May 14, 2016 • edited

highfive commented May 14, 2016

KiChjang commented May 14, 2016

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

highfive commented May 16, 2016

This comment has been minimized.

KiChjang May 16, 2016

This comment has been minimized.

KiChjang May 16, 2016 • edited

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

This comment has been minimized.

KiChjang May 16, 2016

highfive commented May 16, 2016

mrmiywj commented May 16, 2016

KiChjang commented May 16, 2016

highfive commented May 16, 2016

highfive commented May 17, 2016

KiChjang commented May 17, 2016

bors-servo commented May 17, 2016

bors-servo commented May 17, 2016

bors-servo commented May 17, 2016

highfive commented May 17, 2016

highfive commented May 18, 2016

KiChjang commented May 18, 2016

bors-servo commented May 18, 2016

bors-servo commented May 18, 2016

bors-servo commented May 18, 2016

paulrouget commented May 19, 2016

mrmiywj commented May 14, 2016 •

edited

KiChjang May 16, 2016 •

edited