Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused imports #11192

Merged
merged 1 commit into from May 15, 2016
Merged

Removed unused imports #11192

merged 1 commit into from May 15, 2016

Conversation

@perlun
Copy link
Contributor

perlun commented May 15, 2016

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11185
  • These changes do not require tests because it only removes dead code.

This fixes #11185.


This change is Reviewable

This fixes #11185.
@highfive
Copy link

highfive commented May 15, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets.rs, components/style/properties/properties.mako.rs, components/style/viewport.rs, components/style/selector_matching.rs, components/style/media_queries.rs, components/style/font_face.rs
  • @fitzgen: components/profile/mem.rs
  • @KiChjang: components/script/dom/textdecoder.rs, components/script/dom/textencoder.rs, components/script/dom/htmlscriptelement.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/servohtmlparser.rs, components/script/dom/blob.rs, components/script/dom/window.rs, components/script/dom/document.rs, components/script/dom/domquad.rs, components/script/dom/cssstyledeclaration.rs, components/script/task_source/user_interaction.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/dom/element.rs, components/script/dom/htmlfieldsetelement.rs, components/script/dom/htmlformcontrolscollection.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/bindings/weakref.rs, components/script/dom/htmlbodyelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/htmltextareaelement.rs, components/script/dom/worker.rs, components/script/parse/xml.rs, components/script/dom/errorevent.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/net/cookie_storage.rs, components/script/dom/htmlimageelement.rs, components/script/dom/htmlinputelement.rs, components/script/timers.rs, components/script/dom/htmliframeelement.rs, components/script/dom/htmlareaelement.rs, components/script/dom/htmlbuttonelement.rs, components/script/dom/node.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/keyboardevent.rs, components/script/dom/xmldocument.rs, components/script/dom/htmlformelement.rs, components/script/dom/storage.rs, components/script/dom/websocket.rs, components/script/dom/closeevent.rs, components/script/dom/htmlelement.rs, components/script/dom/formdata.rs
@highfive
Copy link

highfive commented May 15, 2016

warning Warning warning

  • These commits modify gfx, style, layout, net, and script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented May 15, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2016

📌 Commit 2f7ed1d has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2016

Testing commit 2f7ed1d with merge 2c674d0...

bors-servo added a commit that referenced this pull request May 15, 2016
Removed unused imports

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11185
- [X] These changes do not require tests because it only removes dead code.

----

This fixes #11185.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11192)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2016

@bors-servo bors-servo merged commit 2f7ed1d into servo:master May 15, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.