Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd link to git-hook tips in HACKING_QUICKSTART.md #11193
Conversation
dlrobertson
changed the title
|
I don't think this is the right place for this information. My intent for the pull request template is to have the minimum amount of information present that will help both reviewers and contributors avoid common mistakes; this feels like a specialized piece of knowledge rather than a particular step to acknowledge. I think this link belongs in another document like the quickstart hacking guide instead. |
|
Good point. That makes sense. I'll move it to the hacking guide. |
|
|
|
@bors-servo r+ |
|
|
Add link to git-hook tips in PR template After a conversation with @aneeshusa on IRC starting [here-ish](http://logs.glob.uno/?c=mozilla%23servo#c430067), info about a [git hook](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks) that runs `test-tidy` on commit (or push) was added to the wiki [here](https://github.com/servo/servo/wiki/Github-workflow#test-tidy-commit-hook). A suggestion was made to also add a link to this in the PR template. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11193) <!-- Reviewable:end -->
KiChjang
changed the title
|
|
dlrobertson commentedMay 15, 2016
•
edited by larsbergstrom
After a conversation with @aneeshusa on IRC starting here-ish, info about a git hook that runs
test-tidyon commit (or push) was added to the wiki here. A suggestion was made to also add a link to this in the PR template.This change is