Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On desktop, use the same app icon we use on Android #11199

Merged
merged 3 commits into from May 16, 2016
Merged

On desktop, use the same app icon we use on Android #11199

merged 3 commits into from May 16, 2016

Conversation

@nox
Copy link
Member

nox commented May 16, 2016

This change is Reviewable

@nox
Copy link
Member Author

nox commented May 16, 2016

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

📌 Commit dab6935 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

Testing commit dab6935 with merge 7cdb9fd...

bors-servo added a commit that referenced this pull request May 16, 2016
On desktop, use the same app icon we use on Android

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

💔 Test failed - linux-dev

This makes the app easier to pick out in Instruments.app and so forth.
@nox nox force-pushed the icon branch from dab6935 to 981ad2d May 16, 2016
@highfive
Copy link

highfive commented May 16, 2016

New code was committed to pull request.

@nox
Copy link
Member Author

nox commented May 16, 2016

Tidy was unhappy.

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

📌 Commit 981ad2d has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

Testing commit 981ad2d with merge 66acb10...

bors-servo added a commit that referenced this pull request May 16, 2016
On desktop, use the same app icon we use on Android

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2016

@bors-servo bors-servo merged commit 981ad2d into master May 16, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced May 16, 2016
@Ms2ger Ms2ger deleted the icon branch May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.