Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake quit-on-escape optional #11200
Make quit-on-escape optional #11200
Conversation
|
|
paulrouget
force-pushed the
paulrouget:quit-on-escape-pref
branch
from
67fb840
to
911a67b
|
There might be a way to test this with webdriver, but even if we decided to do that, it should probably be part of a larger webdriver effort. |
|
|
@bors-servo r+ |
|
|
Make quit-on-escape optional For browserhtml, we don't want Servo to shut down when the user presses the escape key. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11194 Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't know how to test shutdown and how to dispatch a non-DOM key event <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11200) <!-- Reviewable:end -->
|
|
paulrouget commentedMay 16, 2016
•
edited by larsbergstrom
For browserhtml, we don't want Servo to shut down when the user presses the escape key.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsEither:
This change is