Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSuggest a faster tidy. #11201
Suggest a faster tidy. #11201
Conversation
|
So I have some reservations about this, because some PRs do add WPT tests, and sometimes people did not know how to use |
|
@KiChjang I'm afraid you don't have a clue what you're talking about. @bors-servo r+ |
|
|
|
@bors-servo r- In which case, we should just do away the |
|
@bors-servo r+ Fine by me. |
|
|
Suggest a faster tidy. Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [X] These changes do not require tests because documentation update. Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11201) <!-- Reviewable:end -->
|
|
|
heh, given #11217, we're gonna revert this soon :) |
jdm commentedMay 16, 2016
•
edited by larsbergstrom
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
This change is