Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate unions from Typdefs inner type #11203

Closed
wants to merge 1 commit into from
Closed

generate unions from Typdefs inner type #11203

wants to merge 1 commit into from

Conversation

@amarant
Copy link
Contributor

amarant commented May 16, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #10605 (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because _____

It replace PR #10615 and keeps the type hierarchy with typedef.

This change is Reviewable
@highfive
Copy link

highfive commented May 16, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/parser/WebIDL.py, components/script/dom/testbinding.rs, components/script/dom/webidls/TestBinding.webidl
@highfive
Copy link

highfive commented May 16, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented May 16, 2016 •
edited

./mach test-tidy reports errors and ./mach build throws an exception in the WebIDL parser. I'm going to hold off reviewing these changes until those are fixed.
@amarant
Copy link
Contributor Author

amarant commented May 16, 2016

I'm stupid, I didn't commited the tidiness changes.
@amarant
Issue #10605 generate unions from Typdefs inner type
Loading status checks…
6b1495f
@amarant amarant force-pushed the amarant:typdefs branch from 8416c32 to 6b1495f May 16, 2016
@highfive
Copy link

highfive commented May 16, 2016

New code was committed to pull request.
@KiChjang
Copy link
Member

KiChjang commented May 16, 2016

This still doesn't compile.
@amarant
Copy link
Contributor Author

amarant commented May 16, 2016

I don't understand it now, it compiles on my box, I also made clean and recompiled it in debug and release, and my git status says it's clean.
@amarant
Copy link
Contributor Author

amarant commented May 16, 2016 •
edited

The error seems to be that a type of an typdef union is not defined.
@jdm
Copy link
Member

jdm commented May 16, 2016

Huh. I wonder if there's some python caching happening on travis that isn't in local builds for some reason...
@amarant
Copy link
Contributor Author

amarant commented May 16, 2016 •
edited

I've put up my travis and removed the cache dirs and it doesn't fix it, it seems Blob is unresolved : '::Blob'.
@KiChjang KiChjang mentioned this pull request May 17, 2016
Closed
@jdm
Copy link
Member

jdm commented May 17, 2016

I also can't reproduce the build failure locally. This is really annoying!
@jdm
Copy link
Member

jdm commented May 17, 2016

The fact that there are changes to WebIDL.py and that's the file that's complaining is suspicious to me. Why are the changes to that file necessary?
@amarant
Copy link
Contributor Author

amarant commented May 17, 2016

WebIDL.py changes are used to change the way IDLUnionType are flattened, it no longer do a deep flatten but stop at IDLTypedefType.
@amarant
Copy link
Contributor Author

amarant commented May 17, 2016 •
edited

I just installed ubuntu and could reproduce it, so I will look into it. I was on Mac OS before.
@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

☔ The latest upstream changes (presumably #11308) made this pull request unmergeable. Please resolve the merge conflicts.
@KiChjang
Copy link
Member

KiChjang commented Jun 4, 2016

@amarant What's the status here?
@KiChjang
Copy link
Member

KiChjang commented Jul 8, 2016

@amarant Is this still being worked on?
@Scorpil
Copy link
Contributor

Scorpil commented Jul 11, 2016 •
edited

As per IRC chat with @KiChjang , I'll try to drive this forward, as it blocks #10604 and #12341.
@amarant if you decide to finish it up yourself - let me know.
@Scorpil Scorpil mentioned this pull request Jul 11, 2016
Closed
4 of 5 tasks complete
@KiChjang
Copy link
Member

KiChjang commented Jul 11, 2016

Closing in favour of #12397.
@KiChjang KiChjang closed this Jul 11, 2016
@emilio emilio mentioned this pull request Jul 12, 2016
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this pull request Jul 13, 2016
@bors-servo
Auto merge of #12418 - emilio:webidl-update, r=Ms2ger
Loading status checks…
5d98ee6 
WebIDL update

<!-- Please describe your changes on the following line: -->

~~This should help #11203~~ (no, it doesn't, but still worth it).

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12418)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Typdefs are not generated in unions
6 participants
@amarant @highfive @jdm @KiChjang @bors-servo @Scorpil
You can’t perform that action at this time.