Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove misleading nonexistant flag hint #11209
Merged
Conversation
highfive
commented
May 16, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 19, 2016
Remove misleading nonexistant flag hint `./mach build -d` does not report any errors. `./mach test-tidy --faster` does not report any errors. The change fixes #11197. The change does not require tests because it is a small change that doesn't change any core functionality. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11209) <!-- Reviewable:end -->
|
|
highfive
commented
May 19, 2016
|
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 19, 2016
Remove misleading nonexistant flag hint `./mach build -d` does not report any errors. `./mach test-tidy --faster` does not report any errors. The change fixes #11197. The change does not require tests because it is a small change that doesn't change any core functionality. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11209) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
evrimoztamur commentedMay 16, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors../mach test-tidy --fasterdoes not report any errors.The change fixes #11197.
The change does not require tests because it is a small change that doesn't change any core functionality.
This change is