Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading nonexistant flag hint #11209

Merged
merged 1 commit into from May 19, 2016
Merged

Conversation

@evrimoztamur
Copy link

evrimoztamur commented May 16, 2016

./mach build -d does not report any errors.
./mach test-tidy --faster does not report any errors.
The change fixes #11197.

The change does not require tests because it is a small change that doesn't change any core functionality.


This change is Reviewable

@highfive
Copy link

highfive commented May 16, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

@Ms2ger
Copy link
Contributor

Ms2ger commented May 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

📌 Commit b9d3310 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

Testing commit b9d3310 with merge 8274f7e...

bors-servo added a commit that referenced this pull request May 19, 2016
Remove misleading nonexistant flag hint

`./mach build -d` does not report any errors.
`./mach test-tidy --faster` does not report any errors.
The change fixes #11197.

The change does not require tests because it is a small change that doesn't change any core functionality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

💔 Test failed - mac-rel-wpt

@highfive
Copy link

highfive commented May 19, 2016

  ▶ TIMEOUT [expected OK] /cors/redirect-origin.htm
  │ 
  │ thread &#39;http_loader for http://www1.web-platform.test:8000/cors/resources/cors-makeheader.py?origin=*&amp;location=http%3A%2F%2Fwww1.web-platform.test%3A8000%2Fcors%2Fresources%2Fcors-makeheader.py%3Forigin%3Dhttp%3A%2F%2Fwww1.web-platform.test%3A8000%26get_value%3Dlast%2640_1&amp;40_0&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │ stack backtrace:
  │ thread &#39;http_loader for http://www1.web-platform.test:8000/cors/resources/cors-makeheader.py?origin=*&amp;location=http%3A%2F%2Fwww2.web-platform.test%3A8000%2Fcors%2Fresources%2Fcors-makeheader.py%3Forigin%3Dhttp%3A%2F%2Fwww1.web-platform.test%3A8000%26get_value%3Dlast%2641_1&amp;41_0&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, ../src/libstd/rand/mod.rs:159
  │    1:        0x1091df128 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x1091e55b5 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x1091e51ce - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x108974272 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x1091ccd82 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x1091e5b76 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x1091ce678 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x1091e5fe9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │ thread &#39;http_loader for http://www1.web-platform.test:8000/cors/resources/cors-makeheader.py?origin=null&amp;location=http%3A%2F%2Fwww2.web-platform.test%3A8000%2Fcors%2Fresources%2Fcors-makeheader.py%3Forigin%3D*%26get_value%3Dlast%2638_1&amp;38_0&#39; panicked at &#39;could not initialize thread_rng: Too many open files (os error 24)&#39;, /Users/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.3.14/src/lib.rs:873
  │    9:        0x1091cd38c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x107972dac - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x1079b1b00 - net::http_loader::load::h981055a57a1b11f1
  │   12:        0x1079ad7a2 - std::panicking::try::call::h7738ffab0c454f42
  │   13:        0x1091e8d3b - __rust_try
  │   14:        0x1091e8cd5 - __rust_maybe_catch_panic
  │   15:        0x1079afd24 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hfad4324b0bbd8499
  │   16:        0x1</span><span class="stdout">091e45d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8c3c2059 - _pthread_body
  │   18:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x1091df128 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x1091e55b5 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x1091e51ce - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x108974272 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x1091ccd82 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x1091e5b76 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x1091ce678 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x1091e5fe9 - std::rand::thread_rng::THREAD_RNG_KEY::__init::h536e3917997a1628
  │    9:        0x1091cd38c - std::rand::thread_rng::h789d00d1fce4f79b
  │   10:        0x107972dac - _&lt;collections..hash..map..RandomState as core..default..Default&gt;::default::ha847494db5044892
  │   11:        0x1079b1b00 - net::http_loader::load::h981055a57a1b11f1
  │   12:        0x1079ad7a2 - std::panicking::try::call::h7738ffab0c454f42
  │   13:        0x1091e8d3b - __rust_try
  │   14:        0x1091e8cd5 - __rust_maybe_catch_panic
  │   15:        0x1079afd24 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hfad4324b0bbd8499
  │   16:        0x1091e45d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8c3c2059 - _pthread_body
  │   18:     0x7fff8c3c1fd6 - _pthread_start
  │ stack backtrace:
  │    1:        0x1091df128 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x1091e55b5 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x1091e51ce - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x108974272 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x1091ccd82 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x1091e5b76 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x1091ce678 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x1091b703f - rand::thread_rng::THREAD_RNG_KEY::__init::h4e1387a2e4a21393
  │    9:        0x1091b6e7c - rand::thread_rng::he394b446ab605489
  │   10:        0x108bc0562 - uuid::Uuid::new_v4::hc206acac9c7e580d
  │   11:        0x1079b27cb - net::http_loader::load::h981055a57a1b11f1
  │   12:        0x1079ad7a2 - std::panicking::try::call::h7738ffab0c454f42
  │   13:        0x1091e8d3b - __rust_try
  │   14:        0x1091e8cd5 - __rust_maybe_catch_panic
  │   15:        0x1079afd24 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::hfad4324b0bbd8499
  │   16:        0x1091e45d8 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff8c3c2059 - _pthread_body
  └   18:     0x7fff8c3c1fd6 - _pthread_start

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  │ TIMEOUT [expected FAIL] remote (null) to remote2 (*), expect to fail
  └   → Test timed out

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  │ TIMEOUT [expected PASS] remote (*) to remote (http://www1.web-platform.test:8000), expect to fail
  └   → Test timed out

  ▶ Unexpected subtest result in /cors/redirect-origin.htm:
  │ TIMEOUT [expected PASS] remote (*) to remote2 (http://www1.web-platform.test:8000), expect to fail
  └   → Test timed out
@Ms2ger
Copy link
Contributor

Ms2ger commented May 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #11263
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

📌 Commit b9d3310 has been approved by Ms2ger

@Ms2ger
Copy link
Contributor

Ms2ger commented May 19, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

Testing commit b9d3310 with merge be9dfb2...

bors-servo added a commit that referenced this pull request May 19, 2016
Remove misleading nonexistant flag hint

`./mach build -d` does not report any errors.
`./mach test-tidy --faster` does not report any errors.
The change fixes #11197.

The change does not require tests because it is a small change that doesn't change any core functionality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

@bors-servo bors-servo merged commit b9d3310 into servo:master May 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.