New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start on Mach package #11210
Start on Mach package #11210
Conversation
Heads up! This PR modifies the following files:
|
This fails tidy.
|
@edunham Oh sorry. :( I'm so accustomed to seeing this snippet of text that I don't notice unusual things in it anymore... |
apk_path = binary_path + ".apk" | ||
if not path.exists(apk_path): | ||
result = Registrar.dispatch("package", context=self.context, release=release, dev=dev) | ||
if result is not 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The is
binary operator is used to check references. i.e., (IIRC) it's possible for multiple instances of 0
to exist in memory, so this is not guaranteed to always pass. Whereas singletons, like None
, True
, and False
only exist once in memory so is
is okay. So this should maybe be an !=
operator instead
Reviewed 2 of 2 files at r1, 2 of 2 files at r2. Comments from Reviewable |
New code was committed to pull request. |
@larsbergstrom Latest commits do naive packaging for OSX/Linux, including creating ./runservo.sh to invoke Servo with browserhtml. Next steps:
|
63d4672
to
79b983e
Compare
New code was committed to pull request. |
@larsbergstrom It's all squashed up and ready for final review :) |
@CommandProvider | ||
class PackageCommands(CommandBase): | ||
@Command('package', | ||
description='Package Servo (currently, Android APK only)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is now incorrect :-)
After fixing the one total nit, please squash and r=me! |
|
@edunham Please fix tidy and r=me. |
description='Install Servo (currently, Android only)', | ||
category='package') | ||
@CommandArgument('--release', '-r', action='store_true', | ||
help='Package the release build') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Package' -> 'Install'
* Split package commands into their own file * Delete spurious files from build dir * Create runservo.sh to invoke servo with the right browserhtml incantation * Tar it all up with the date and time in the filename
New code was committed to pull request. |
Latest changes fix tidy errors and switch to using ISO datetime format. |
I don't think the |
@aneeshusa I'd like to get a basic package functionality landed so we can add it to the build system -- in the long run there are a lot of areas for improvement. |
@bors-servo r+ |
📌 Commit a1a8e08 has been approved by |
Start on Mach package Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [ ] `./mach build -d` does not report any errors - these changes don't touch anything that mach build touches> - [ ] `./mach test-tidy --faster` does not report any errors - Tidy errors on some dependencies that I think we'll need for real `package` but aren't using for android - [X] These changes address #9918 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't think Mach has tests yet? Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11210) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
servo/servo#11210 recently updated `./mach package` to make it a first-class Mach command and add support for simple Linux packaging as well (in the form of tarballs). Android used to be the only packaging target supported, so a naked `./mach package` sufficed, but now we need to explicitly build the Android packaging.
…larsbergstrom Add --android option to ./mach package servo/servo#11210 recently updated `./mach package` to make it a first-class Mach command and add support for simple Linux packaging as well (in the form of tarballs). Android used to be the only packaging target supported, so a naked `./mach package` sufficed, but now we need to explicitly build the Android packaging. Another step for servo/servo#10339. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/401) <!-- Reviewable:end -->
Thank you for contributing to Servo! Please replace each
[ ]
by[X]
when the step is complete, and replace__
with appropriate data:./mach build -d
does not report any errors./mach test-tidy --faster
does not report any errorspackage
but aren't using for androidEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
This change is