Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History API #11220

Closed
wants to merge 10 commits into from

Fix debug messages

Address other comments

Remove duplicate popstate event binding
  • Loading branch information
cbrewster committed May 28, 2016
commit 4298c1eef25c04aaf86d5125d8cce096482caec2
@@ -678,12 +678,12 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
}
// Handle request for history length
Request::Script(FromScriptMsg::HistoryLength(sender)) => {
debug!("constellation got history length message from compositor");
debug!("constellation got history length message from script");
self.handle_history_length(sender);
}
// Handle pushing a history entry due to state change
Request::Script(FromScriptMsg::HistoryStatePushed(pipeline_info, active_index)) => {
debug!("constellation got history length message from compositor");
debug!("constellation got history state pushed message from script");
self.handle_history_state_pushed(pipeline_info, active_index);
}
// Notification that the new document is ready to become active
@@ -199,7 +199,7 @@ impl<'a> GlobalRef<'a> {
}
}

/// `ScriptChan` used to send messages to the event loop of this global's
/// `TaskSource` used to queue history taversal messages to the event loop of this global's
/// thread.
pub fn history_traversal_task_source(&self) -> Box<TaskSource<HistoryTraversalTask> + Send> {
match *self {
@@ -605,9 +605,6 @@ impl WindowMethods for Window {
// https://html.spec.whatwg.org/multipage/#windoweventhandlers
window_event_handlers!();

// https://html.spec.whatwg.org/multipage/#handler-window-onpopstate
event_handler!(popstate, GetOnpopstate, SetOnpopstate);

// https://developer.mozilla.org/en-US/docs/Web/API/Window/screen
fn Screen(&self) -> Root<Screen> {
self.screen.or_init(|| Screen::new(self))
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.