Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.10.0-nightly (cd6a40017 2016-05-16) #11231

Merged
merged 2 commits into from May 17, 2016
Merged

Update Rust to 1.10.0-nightly (cd6a40017 2016-05-16) #11231

merged 2 commits into from May 17, 2016

Conversation

@nox
Copy link
Member

nox commented May 17, 2016

This change is Reviewable

@highfive
Copy link

highfive commented May 17, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/eventtarget.rs, components/script/dom/htmlelement.rs
@highfive
Copy link

highfive commented May 17, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented May 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2016

📌 Commit 60aaac5 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2016

Testing commit 60aaac5 with merge 82036b5...

bors-servo added a commit that referenced this pull request May 17, 2016
Update Rust to 1.10.0-nightly (cd6a40017 2016-05-16)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11231)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2016

💔 Test failed - mac-rel-wpt

@highfive
Copy link

highfive commented May 17, 2016

  ▶ CRASH [expected TIMEOUT] /workers/semantics/encodings/004.worker
  │ 
  │ thread &#39;WebWorker for http://web-platform.test:8000/workers/semantics/encodings/004.worker.js&#39; panicked at &#39;called `Result::unwrap()` on an `Err` value: FromUtf8Error { bytes: [105, 109, 112, 111, 114, 116, 83, 99, 114, 105, 112, 116, 115, 40, 34, 47, 114, 101, 115, 111, 117, 114, 99, 101, 115, 47, 116, 101, 115, 116, 104, 97, 114, 110, 101, 115, 115, 46, 106, 115, 34, 41, 59, 10, 116, 101, 115, 116, 40, 102, 117, 110, 99, 116, 105, 111, 110, 40, 41, 32, 123, 10, 32, 32, 97, 115, 115, 101, 114, 116, 95, 101, 113, 117, 97, 108, 115, 40, 34, 255, 34, 44, 32, 34, 92, 117, 102, 102, 102, 100, 34, 41, 59, 10, 125, 44, 32, 34, 68, 101, 99, 111, 100, 105, 110, 103, 32, 105, 110, 118, 97, 108, 105, 100, 32, 117, 116, 102, 45, 56, 34, 41, 59, 10, 100, 111, 110, 101, 40, 41, 59, 10], error: Utf8Error { valid_up_to: 79 } }&#39;, ../src/libcore/result.rs:785
  │ stack backtrace:
  │    1:        0x10bbf16a8 - std::sys::backtrace::tracing::imp::write::h9fb600083204ae7f
  │    2:        0x10bbf7b35 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::hca543c34f11229ac
  │    3:        0x10bbf774e - std::panicking::default_hook::hc2c969e7453d080c
  │    4:        0x10b333482 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │    5:        0x10bbdf3c2 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │    6:        0x10bbf80f6 - std::panicking::begin_panic::h4889569716505182
  │    7:        0x10bbe0cb8 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │    8:        0x10bbf7d4f - rust_begin_unwind
  │    9:        0x10bc1f540 - core::panicking::panic_fmt::h257ceb0aa351d801
  │   10:        0x10ad64e37 - core::result::unwrap_failed::hf6c09f6181fb0aed
  │   11:        0x10ad635b9 - script::dom::dedicatedworkerglobalscope::DedicatedWorkerGlobalScope::run_worker_scope::_$u7b$$u7b$closure$u7d$$u7d$::h15f9e1afc6a0cd00
  │   12:        0x10ad6469f - std::panicking::try::call::hacb70a37009bf82f
  │   13:        0x10bbfb2bb - __rust_try
  │   14:        0x10bbfb255 - __rust_maybe_catch_panic
  │   15:        0x10ad64954 - _&lt;F as std..boxed..FnBox&lt;A&gt;&gt;::call_box::h4edca254635c3085
  │   16:        0x10bbf6b58 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │   17:     0x7fff95828059 - _pthread_body
  └   18:     0x7fff95827fd6 - _pthread_start
@jdm
Copy link
Member

jdm commented May 17, 2016

(metadata.final_url, String::from_utf8(bytes).unwrap())
, j'accuse!

@nox
Copy link
Member Author

nox commented May 17, 2016

@jdm Do you mean that you don't think it's an intermittent failure?

@nox
Copy link
Member Author

nox commented May 17, 2016

Arguably, CRASH is better than TIMEOUT anyway. :P

@nox
Copy link
Member Author

nox commented May 17, 2016

Restarted that build to see if it fails again: http://build.servo.org/builders/mac-rel-wpt/builds/1061

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2016

@bors-servo bors-servo merged commit 60aaac5 into master May 17, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the rustup branch May 17, 2016
@nox
Copy link
Member Author

nox commented May 17, 2016

The failure was #11234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.