Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report panics in web worker threads. #11244

Merged
merged 1 commit into from May 18, 2016
Merged

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 18, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #11234 (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented May 18, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/worker.rs, components/script/dom/bindings/global.rs, components/script/dom/workerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_thread.rs, components/script/dom/window.rs
@highfive

This comment has been minimized.

Copy link

highfive commented May 18, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger

This comment has been minimized.

Copy link
Contributor Author

Ms2ger commented May 18, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 18, 2016

⌛️ Trying commit 71dc1f3 with merge 89b1922...

bors-servo added a commit that referenced this pull request May 18, 2016
Report panics in web worker threads.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #11234 (github issue number if applicable).

Either:
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 18, 2016

💔 Test failed - mac-rel-wpt

@highfive

This comment has been minimized.

Copy link

highfive commented May 18, 2016

  ▶ CRASH [expected TIMEOUT] /workers/semantics/encodings/004.worker
  │ 
  │ ERROR:compositing::constellation: Panic: called `Result::unwrap()` on an `Err` value: FromUtf8Error { bytes: [105, 109, 112, 111, 114, 116, 83, 99, 114, 105, 112, 116, 115, 40, 34, 47, 114, 101, 115, 111, 117, 114, 99, 101, 115, 47, 116, 101, 115, 116, 104, 97, 114, 110, 101, 115, 115, 46, 106, 115, 34, 41, 59, 10, 116, 101, 115, 116, 40, 102, 117, 110, 99, 116, 105, 111, 110, 40, 41, 32, 123, 10, 32, 32, 97, 115, 115, 101, 114, 116, 95, 101, 113, 117, 97, 108, 115, 40, 34, 255, 34, 44, 32, 34, 92, 117, 102, 102, 102, 100, 34, 41, 59, 10, 125, 44, 32, 34, 68, 101, 99, 111, 100, 105, 110, 103, 32, 105, 110, 118, 97, 108, 105, 100, 32, 117, 116, 102, 45, 56, 34, 41, 59, 10, 100, 111, 110, 101, 40, 41, 59, 10], error: Utf8Error { valid_up_to: 79 } }
  │ ERROR:compositing::constellation: Backtrace:
  │ frame #0  - 0x000000010a7a76be - backtrace::backtrace::trace::h970e6004c9e40bad
  │ frame #1  - 0x000000010a7a7641 - backtrace::capture::Backtrace::new::hcd7fdea4950c7315
  │ frame #2  - 0x000000010a1a7e56 - _<F as std..boxed..FnBox<A>>::call_box::h56ec380a460416d2
  │ frame #3  - 0x000000010a798bfa - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x000000010aff5342 - std::panicking::rust_panic_with_hook::hfe203e3083c2b544
  │ frame #5  - 0x000000010b00e136 - std::panicking::begin_panic::h4889569716505182
  │ frame #6  - 0x000000010aff6c38 - std::panicking::begin_panic_fmt::h484cd47786497f03
  │ frame #7  - 0x000000010b00dd8f - rust_begin_unwind
  │ frame #8  - 0x000000010b035580 - core::panicking::panic_fmt::h257ceb0aa351d801
  │ frame #9  - 0x000000010a1ae6c7 - core::result::unwrap_failed::hf6c09f6181fb0aed
  │ frame #10 - 0x000000010a1ad653 - script::dom::dedicatedworkerglobalscope::DedicatedWorkerGlobalScope::run_worker_scope::_$u7b$$u7b$closure$u7d$$u7d$::h15f9e1afc6a0cd00
  │ frame #11 - 0x000000010a1a65f9 - std::panicking::try::call::hdeb0d583e2e0106b
  │ frame #12 - 0x000000010b0112fb - __rust_try
  │ frame #13 - 0x000000010b011295 - __rust_maybe_catch_panic
  │ frame #14 - 0x000000010a1a69b4 - _<F as std..boxed..FnBox<A>>::call_box::h17f3c013c74322b3
  │ frame #15 - 0x000000010b00cb98 - std::sys::thread::Thread::new::thread_start::h6f266e069bf4ec2b
  │ frame #16 - 0x00007fff8c3c2059 - _pthread_body
  │ frame #17 - 0x00007fff8c3c1fd6 - _pthread_start
  │ 
  └ ERROR:compositing::constellation: Pipeline failed in hard-fail mode.  Crashing!
@Ms2ger Ms2ger force-pushed the Ms2ger:catch-panics-workers branch from 71dc1f3 to 1ebe681 May 18, 2016
@highfive

This comment has been minimized.

Copy link

highfive commented May 18, 2016

New code was committed to pull request.

@nox

This comment has been minimized.

Copy link
Member

nox commented May 18, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 18, 2016

📌 Commit 1ebe681 has been approved by nox

@highfive highfive assigned nox and unassigned glennw May 18, 2016
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 18, 2016

⌛️ Testing commit 1ebe681 with merge bed6d45...

bors-servo added a commit that referenced this pull request May 18, 2016
Report panics in web worker threads.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #11234 (github issue number if applicable).

Either:
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11244)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 18, 2016

@bors-servo bors-servo merged commit 1ebe681 into servo:master May 18, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:catch-panics-workers branch May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.