Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated etc/ci/check_no_unwrap.sh for new constellation crate. #11249

Merged

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented May 18, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • No github issue.

Either:

  • There are tests for these changes OR
  • These changes do not require tests because this is updating our CI test code.

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@asajeffrey
Copy link
Member Author

asajeffrey commented May 18, 2016

r? @Ms2ger

@highfive highfive assigned Ms2ger and unassigned larsbergstrom May 18, 2016
@asajeffrey
Copy link
Member Author

asajeffrey commented May 18, 2016

This PR is an update to #11243.

@KiChjang
Copy link
Member

KiChjang commented May 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

📌 Commit d16d2a0 has been approved by KiChjang

@highfive highfive assigned KiChjang and unassigned Ms2ger May 19, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

Testing commit d16d2a0 with merge dea6109...

bors-servo added a commit that referenced this pull request May 19, 2016
…rate, r=KiChjang

Updated etc/ci/check_no_unwrap.sh for new constellation crate.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [X] No github issue.

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is updating our CI test code.

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11249)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2016

@bors-servo bors-servo merged commit d16d2a0 into servo:master May 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.