Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up11158 - add event handlers #11255
Merged
11158 - add event handlers #11255
+395
−883
Conversation
highfive
commented
May 18, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon. |
highfive
commented
May 18, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 18, 2016
|
|
|
@bors-servo try |
|
|
bors-servo
added a commit
that referenced
this pull request
May 19, 2016
11158 - add event handlers Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy --faster` does not report any errors - [X] These changes fix #11158 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11255) <!-- Reviewable:end -->
|
|
highfive
commented
May 19, 2016
|
|
@s-baldrick here is a guide on updating the test expectations https://github.com/servo/servo/tree/master/tests/wpt#updating-test-expectations. On the failure in Thank you for this work! |
| use string_cache::Atom; | ||
| use util::str::DOMString; | ||
|
|
||
| #[dom_struct] |
This comment has been minimized.
This comment has been minimized.
cbrewster
May 19, 2016
•
Member
Could we add a comment linking to https://html.spec.whatwg.org/multipage/#beforeunloadevent above this line?
|
@bors-servo delegate=ConnorGBrewster |
|
|
|
r? @ConnorGBrewster |
|
Looks good! Thank you for doing this! After fixing my suggestions + updating test expectations, this should be good!
|
|
Thanks for the feedback :)
|
highfive
commented
May 19, 2016
|
New code was committed to pull request. |
|
Review status: 13 of 21 files reviewed at latest revision, 2 unresolved discussions. components/script/dom/beforeunloadevent.rs, line 19 [r4] (raw file):
|
|
@s-baldrick could you squash these commits? Then it would be good to go |
Adding: * global event handlers, * window event handlers, * document and element handlers, * and support for BeforeUnloadEvent. Signed-off-by: Piotr Stankiewicz <bionicrift@gmail.com>
|
@bors-servo r+ Git. |
|
|
|
|
Ugh. @bors-servo r=ConnorGBrewster retry |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
May 20, 2016
11158 - add event handlers Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy --faster` does not report any errors - [X] These changes fix #11158 (github issue number if applicable). Either: - [x] There are tests for these changes OR - [ ] These changes do not require tests because ____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11255) <!-- Reviewable:end -->
|
|
highfive
commented
May 20, 2016
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
May 21, 2016
11158 - add event handlers Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy --faster` does not report any errors - [X] These changes fix #11158 (github issue number if applicable). Either: - [x] There are tests for these changes OR - [ ] These changes do not require tests because ____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11255) <!-- Reviewable:end -->
|
@bors-servo force retry |
bors-servo
added a commit
that referenced
this pull request
May 21, 2016
11158 - add event handlers Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy --faster` does not report any errors - [X] These changes fix #11158 (github issue number if applicable). Either: - [x] There are tests for these changes OR - [ ] These changes do not require tests because ____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11255) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
s-baldrick commentedMay 18, 2016
•
edited by cbrewster
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidy --fasterdoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
This change is