Implement [Func] #11308

nox · 2016-05-20T22:37:39Z

First part of #11292, this just includes support of [Func].

This change is

highfive · 2016-05-20T22:37:43Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/testbinding.rs, components/script/dom/bindings/mod.rs, components/script/dom/bindings/utils.rs, components/script/dom/bindings/guard.rs, components/script/dom/webidls/TestBinding.webidl, components/script/dom/bindings/interface.rs

highfive · 2016-05-20T22:37:44Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

nox · 2016-05-20T22:37:47Z

r? @jdm

nox · 2016-05-20T22:38:42Z

@bors-servo try

bors-servo · 2016-05-20T22:38:46Z

⌛ Trying commit dd16933 with merge 524bf1a...


        Auto merge of #11308 - nox:guarded, r=<try>

Implement [Func] First part of #11292, this just includes support of `[Func]`.

bors-servo · 2016-05-20T22:59:51Z

⛄ The build was interrupted to prioritize another pull request.

bors-servo · 2016-05-20T22:59:54Z

⌛ Trying commit dd16933 with merge ef4e165...


        Auto merge of #11308 - nox:guarded, r=<try>

Implement [Func] First part of #11292, this just includes support of `[Func]`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11308)

highfive · 2016-05-20T23:00:37Z

New code was committed to pull request.

nox · 2016-05-20T23:24:22Z

@bors-servo try

bors-servo · 2016-05-20T23:24:26Z

⌛ Trying commit 3e2a6e4 with merge b09a890...


        Auto merge of #11308 - nox:guarded, r=<try>

Implement [Func] First part of #11292, this just includes support of `[Func]`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11308)

bors-servo · 2016-05-21T00:45:59Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive · 2016-05-23T23:16:44Z

New code was committed to pull request.

highfive · 2016-05-23T23:23:19Z

New code was committed to pull request.

highfive · 2016-05-23T23:29:11Z

New code was committed to pull request.

nox · 2016-05-23T23:30:22Z

I've added a few commits that conditionally-define HTMLIFrameElement.mozbrowser.

bors-servo · 2016-05-24T09:59:19Z

☔ The latest upstream changes (presumably #11326) made this pull request unmergeable. Please resolve the merge conflicts.

highfive · 2016-05-24T11:47:48Z

New code was committed to pull request.

jdm · 2016-05-26T17:33:37Z

Nice work! I appreciated how the commits were broken up.
-S-awaiting-review +S-needs-code-changes

Previously, highfive wrote…

New code was committed to pull request.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 3 of 3 files at r4, 5 of 5 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 5 of 5 files at r9, 2 of 2 files at r10, 6 of 6 files at r11, 3 of 3 files at r12, 17 of 17 files at r13, 1 of 1 files at r14, 2 of 2 files at r15, 3 of 3 files at r16, 5 of 5 files at r17, 1 of 1 files at r18, 1 of 1 files at r19, 1 of 1 files at r20, 5 of 5 files at r21, 2 of 2 files at r22, 6 of 6 files at r23, 3 of 3 files at r24, 1 of 1 files at r25, 17 of 17 files at r26, 1 of 1 files at r27, 2 of 2 files at r28, 3 of 3 files at r29, 5 of 5 files at r30, 1 of 1 files at r31, 1 of 1 files at r32, 1 of 1 files at r33, 5 of 5 files at r34, 2 of 2 files at r35, 6 of 6 files at r36, 3 of 3 files at r37, 4 of 4 files at r38, 3 of 3 files at r39.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/bindings/codegen/CodegenRust.py, line 1336 [r1] (raw file):

    assert pref is None or isinstance(pref, str)
    assert func is None or isinstance(func, str)
    if pref is not None:

if pref:

components/script/dom/bindings/codegen/CodegenRust.py, line 1340 [r39] (raw file):

    if pref is not None:
        return 'Condition::Pref("%s")' % pref
    if func is not None:

if func:

Comments from Reviewable


        Make MemberCondition a function returning a plain string


        Use itertools.groupby in generatePrefableArray


        Simplify how Prefable arrays are passed in bindings::interface


        Remove Prefable::terminator 🤖


        Remove utils::Prefable in favour of guard::Guard


        Make define_constants private


        Remove some 'static lifetimes from bindings::interface


        Rename receiver to global in bindings::interface

highfive · 2016-05-26T21:57:13Z

New code was committed to pull request.

jdm · 2016-05-26T22:08:35Z

As far as I can see, we're not actually testing the new properties and methods that were added to TestBinding. We should add them to the interface_member_exposed.html test.
-S-awaiting-review +S-needs-tests

Previously, highfive wrote…

New code was committed to pull request.

Reviewed 17 of 17 files at r40, 1 of 1 files at r41, 2 of 2 files at r42, 3 of 3 files at r43, 5 of 5 files at r44, 1 of 1 files at r45, 1 of 1 files at r46, 1 of 1 files at r47, 5 of 5 files at r48, 2 of 2 files at r49, 6 of 6 files at r50, 3 of 3 files at r51.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


        Implement [Func]


        Clean up the functions to retrieve a global root from JS objects


        Move mozbrowser_enabled to util::prefs


        Use [Func] on HTMLIFrameElement.mozbrowser

highfive · 2016-05-26T22:55:13Z

New code was committed to pull request.

nox · 2016-05-26T22:55:43Z

@jdm I added the test you wanted.

Ms2ger · 2016-05-27T09:25:58Z

@bors-servo r=jdm

bors-servo · 2016-05-27T09:25:59Z

📌 Commit 694deab has been approved by jdm

bors-servo · 2016-05-27T09:45:07Z

⌛ Testing commit 694deab with merge 073c5e3...


        Auto merge of #11308 - nox:guarded, r=jdm

Implement [Func] First part of #11292, this just includes support of `[Func]`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11308)

bors-servo · 2016-05-27T10:33:12Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

nox added the A-content/bindings label May 20, 2016

highfive assigned SimonSapin May 20, 2016

highfive added the S-awaiting-review label May 20, 2016

highfive assigned jdm and unassigned SimonSapin May 20, 2016

bors-servo added a commit that referenced this pull request May 20, 2016

Auto merge of #11308 - nox:guarded, r=<try>

524bf1a

Implement [Func] First part of #11292, this just includes support of `[Func]`.

nox force-pushed the nox:guarded branch from dd16933 to 3e2a6e4 May 20, 2016

nox force-pushed the nox:guarded branch from bc1fe06 to 9322c37 May 23, 2016

nox force-pushed the nox:guarded branch from 9322c37 to 0cff169 May 23, 2016

nox force-pushed the nox:guarded branch 2 times, most recently from 79493fa to 7d5ffec May 24, 2016

nox added 8 commits May 20, 2016

Make MemberCondition a function returning a plain string

b094932

Use itertools.groupby in generatePrefableArray

bee6f59

Simplify how Prefable arrays are passed in bindings::interface

adcecda

Remove Prefable::terminator 🤖

a20db08

Remove utils::Prefable in favour of guard::Guard

fd7c4f8

Make define_constants private

25aaf78

Remove some 'static lifetimes from bindings::interface

f0b5393

Rename receiver to global in bindings::interface

0d04acd

nox force-pushed the nox:guarded branch from 7d5ffec to ca83b85 May 26, 2016

nox added 4 commits May 20, 2016

Implement [Func]

e179cb0

Clean up the functions to retrieve a global root from JS objects

34858fd

Move mozbrowser_enabled to util::prefs

34dfc28

Use [Func] on HTMLIFrameElement.mozbrowser

Loading status checks…

694deab

nox force-pushed the nox:guarded branch from ca83b85 to 694deab May 26, 2016

bors-servo merged commit 694deab into servo:master May 27, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bors-servo mentioned this pull request May 27, 2016

generate unions from Typdefs inner type #11203

Closed

4 of 5 tasks complete

paulrouget mentioned this pull request May 30, 2016

I don't understand how the new mozbrowser API privilege works #11498

Closed

nox mentioned this pull request Mar 1, 2017

Kill serde_codegen 💣 #15769

Merged

servo / servo

Implement [Func] #11308

Implement [Func] #11308

nox commented May 20, 2016 •

edited by larsbergstrom

highfive commented May 20, 2016

highfive commented May 20, 2016

nox commented May 20, 2016

nox commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 20, 2016

highfive commented May 20, 2016

nox commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 21, 2016

highfive commented May 23, 2016

highfive commented May 23, 2016

highfive commented May 23, 2016

nox commented May 23, 2016

bors-servo commented May 24, 2016

highfive commented May 24, 2016

jdm commented May 26, 2016

highfive commented May 26, 2016

jdm commented May 26, 2016

highfive commented May 26, 2016

nox commented May 26, 2016

Ms2ger commented May 27, 2016

bors-servo commented May 27, 2016

bors-servo commented May 27, 2016

bors-servo commented May 27, 2016

servo / servo

Join GitHub today

Implement [Func] #11308

Implement [Func] #11308

Conversation

nox commented May 20, 2016 • edited by larsbergstrom

highfive commented May 20, 2016

highfive commented May 20, 2016

nox commented May 20, 2016

nox commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 20, 2016

highfive commented May 20, 2016

nox commented May 20, 2016

bors-servo commented May 20, 2016

bors-servo commented May 21, 2016

highfive commented May 23, 2016

highfive commented May 23, 2016

highfive commented May 23, 2016

nox commented May 23, 2016

bors-servo commented May 24, 2016

highfive commented May 24, 2016

jdm commented May 26, 2016

highfive commented May 26, 2016

jdm commented May 26, 2016

highfive commented May 26, 2016

nox commented May 26, 2016

Ms2ger commented May 27, 2016

bors-servo commented May 27, 2016

bors-servo commented May 27, 2016

bors-servo commented May 27, 2016

nox commented May 20, 2016 •

edited by larsbergstrom