Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that a navigation to the same URL is aborted. Fixes #10952. #11321

Closed
wants to merge 1 commit into from

Conversation

@emilio
Copy link
Member

emilio commented May 21, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #10952 (github issue number if applicable).

Either:

  • There are tests for these changes.

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


Rebase of #10954

r? @jdm for the rebase (r=me for the original changes)

@jdm: Should this test still live in wpt? I'm tempted to move it to mozilla/ until whatwg/html#1177 is resolved.


This change is Reviewable

@highfive
Copy link

highfive commented May 21, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/script_thread.rs
@jdm
Copy link
Member

jdm commented May 25, 2016

I agree, we should keep it as a local test until we achieve consensus.

@jdm
Copy link
Member

jdm commented May 25, 2016

I'm tempted to fix this in the same manner as Gecko instead. Location::SetHash can check for an empty string and pass "#" instead, which will set the fragment to Some("") rather than None, which means the existing navigation short-circuit code will Just Work.

@jdm
Copy link
Member

jdm commented May 25, 2016

whatwg/html#1318 agrees with me.

@bors-servo
Copy link
Contributor

bors-servo commented May 27, 2016

The latest upstream changes (presumably #11434) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm jdm added this to the Tech Demo milestone Jun 29, 2016
@Manishearth Manishearth removed this from the Tech Demo milestone Jun 29, 2016
@jdm
Copy link
Member

jdm commented Jun 29, 2016

Closed in favour of #11934.

@jdm jdm closed this Jun 29, 2016
@KiChjang
Copy link
Member

KiChjang commented Jul 2, 2016

#11934 is about a special case location hash string, whereas this is about preventing navigation to the same URL. Should this be reopened?

@emilio emilio deleted the emilio:navigatefragment branch Jul 2, 2016
@emilio
Copy link
Member Author

emilio commented Jul 2, 2016

@KiChjang: I don't think so, this was a way to tackle the same underlying problem, but the spec resolution was to take the approach of #11934 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.