Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure that a navigation to the same URL is aborted. Fixes #10952. #11321
Conversation
highfive
commented
May 21, 2016
|
Heads up! This PR modifies the following files:
|
|
I agree, we should keep it as a local test until we achieve consensus. |
|
I'm tempted to fix this in the same manner as Gecko instead. Location::SetHash can check for an empty string and pass |
|
whatwg/html#1318 agrees with me. |
|
|
|
Closed in favour of #11934. |
|
#11934 is about a special case location hash string, whereas this is about preventing navigation to the same URL. Should this be reopened? |
emilio commentedMay 21, 2016
•
edited by larsbergstrom
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidy --fasterdoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Rebase of #10954
r? @jdm for the rebase (r=me for the original changes)
@jdm: Should this test still live in wpt? I'm tempted to move it to
mozilla/until whatwg/html#1177 is resolved.This change is